Skip to content

Add bottom dock tab style setting - #113065

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:Outdock
Nov 25, 2025
Merged

Add bottom dock tab style setting#113065
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:Outdock

Conversation

@KoBeWi

@KoBeWi KoBeWi commented Nov 22, 2025

Copy link
Copy Markdown
Member

Fixes #113054

This PR adds a new interface/editor/bottom_dock_tab_style editor setting, which can be used to set the tab style for bottom docks separately (I assume most users wouldn't want them icon-only, even if they use that option for vertical docks, idk).

Also adds a new EditorDock property - force_show_icon. EditorLog (aka Output) uses it to display error icon even if tabs are text-only.

And finally, Output is now EditorDock (part of #113024). I assigned it a new icon, which is error icon but white
image
It only shows when bottom dock icons are enabled (other docks don't have icons yet).

@KoBeWi KoBeWi added this to the 4.6 milestone Nov 22, 2025
@KoBeWi
KoBeWi requested a review from a team as a code owner November 22, 2025 18:09
@KoBeWi KoBeWi added the bug label Nov 22, 2025
@KoBeWi
KoBeWi requested a review from a team November 22, 2025 18:09
@KoBeWi
KoBeWi requested a review from a team as a code owner November 22, 2025 18:09
@KoBeWi KoBeWi changed the title Add bottom tab style setting Add bottom dock tab style setting Nov 22, 2025
Comment thread doc/classes/EditorDock.xml Outdated

@Mickeon Mickeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new editor setting feels like a bit of a hack, I can't quite put why.
Maybe it's because interface/editor/dock_tab_style is now oddly ambiguous in both name and description. I would suggest at least changing its original description, too. Preferably the setting should be renamed, but perhaps that's overkill because all of this logic is emerging just to retain the same features as before during this refactoring.

@Mickeon Mickeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs ok. But the docks should be okay, too.

Comment thread editor/editor_node.cpp
@lodetrick

lodetrick commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

To be honest I don't think we need the editor setting just yet; the bottom dock with only icons does look weird right now but once all of the bottom docks are converted it will look a lot better. I think the feeling is just because of how uneven it is. The editor setting also feels like future-proofing, I think it should be included it if reports are coming in about the icons on the bottom panel but I think its just too early to tell.

@KoBeWi

KoBeWi commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

We have 17 bottom docks. Only 5 of them are always visible, the others will appear and disappear and change positions, it's very different from the side docks. Also you have lots of space at the bottom, so icon-only mode does not really help with anything. I doubt people will use it much, even if they use it for the side docks.

@Repiteo
Repiteo merged commit 8c76d71 into godotengine:master Nov 25, 2025
20 checks passed
@Repiteo

Repiteo commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Thanks!

@KoBeWi
KoBeWi deleted the Outdock branch November 25, 2025 16:08
@lodetrick

lodetrick commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

I pulled from master and the icons don't update properly, the setting only goes into effect if I close the editor and reopen it, or force an update by moving dock to another slot.

Edit: Both settings now don't update properly

@KoBeWi

KoBeWi commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

Yeah, I noticed it and just made a fix. Will push soon.

@Maran23

Maran23 commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

One note from my side: With #113051 as a potential improvement, the interface/editor/bottom_dock_tab_style might not be the best name then. As you may could even put those docks at the top. Then something like interface/editor/horizontal_dock_tab_style would fit better. Just something for consideration in the future.

@KoBeWi

KoBeWi commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

Main screen docks will get another setting (it will be the last one).
Although we might get another horizontal dock slot, so maybe the name is not ideal. For now it works though.

BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
Add bottom dock tab style setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output shows as only icon if you set dock tab style to icon-only

7 participants