Change MSBuildPanel to EditorDock - #113115
Merged
Merged
Conversation
18 tasks
raulsntos
requested changes
Nov 25, 2025
raulsntos
left a comment
raulsntos
left a comment
Member
There was a problem hiding this comment.
Only reviewing the commit that contains the C# changes. The changes look mostly good, except for a few code style nitpicks. But when I tested, I run into an error.
When building a C# project with errors, instead of opening the MSBuild dock it throws an error:
ERROR: Parameter "dock" is null.
at: make_item_visible (./editor/gui/editor_bottom_panel.cpp:151)
C# backtrace (most recent call first):
[0] void Godot.NativeCalls.godot_icall_1_2(nint, nint, nint) (/src/godot/modules/mono/glue/GodotSharp/GodotSharp/Generated/NativeCalls.cs:37)
[1] void Godot.EditorPlugin.MakeBottomPanelItemVisible(Godot.Control) (/src/godot/modules/mono/glue/GodotSharp/GodotSharpEditor/Generated/GodotObjects/EditorPlugin.cs:729)
[2] void GodotTools.Build.BuildManager.ShowBuildErrorDialog(string) (/src/godot/modules/mono/editor/GodotTools/GodotTools/Build/BuildManager.cs:55)
[3] bool GodotTools.Build.BuildManager.BuildProjectBlocking(GodotTools.Build.BuildInfo) (/src/godot/modules/mono/editor/GodotTools/GodotTools/Build/BuildManager.cs:233)
[4] bool GodotTools.Build.BuildManager.BuildProjectBlocking(string, string, bool) (/src/godot/modules/mono/editor/GodotTools/GodotTools/Build/BuildManager.cs:320)
[5] void GodotTools.Build.MSBuildPanel.BuildProject() (/src/godot/modules/mono/editor/GodotTools/GodotTools/Build/MSBuildPanel.cs:79)
[6] void GodotTools.GodotSharpEditor.BuildProjectPressed() (/src/godot/modules/mono/editor/GodotTools/GodotTools/GodotSharpEditor.cs:154)
[7] void Godot.Callable.<From>g__Trampoline|1_0(object, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant&) (/src/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Callable.generics.cs:39)
[8] void Godot.DelegateUtils.InvokeWithVariantArgs(nint, System.Void*, Godot.NativeInterop.godot_variant**, int, Godot.NativeInterop.godot_variant*) (/src/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/DelegateUtils.cs:86)
Since the MSBuildPanel instance is no longer added as a bottom panel item, it looks like we may need to change this line:
lodetrick
approved these changes
Nov 26, 2025
Mickeon
approved these changes
Nov 26, 2025
| <method name="make_visible"> | ||
| <return type="void" /> | ||
| <description> | ||
| Focuses the dock's tab (or window if it's floating). If the dock was closed, it will be opened. If it's a bottom dock, makes the bottom panel visible. |
Member
There was a problem hiding this comment.
Believe it or not we rarely use "focus" as an actual verb. Oftentimes it's something like "gain/grab focus", "receive the focus" "has focus", etc.
However, there is one occurrence of "open and focus the dock" in add_control_to_dock in EditorDock, so maybe that's fine...
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Change MSBuildPanel to EditorDock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #113024