Update dock tabs on setting change - #113167
Merged
Merged
Conversation
Mickeon
approved these changes
Nov 25, 2025
Mickeon
left a comment
Mickeon
left a comment
Member
There was a problem hiding this comment.
Approving based on prior comments but I have not tested this myself
akien-mga
approved these changes
Nov 25, 2025
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Update dock tabs on setting change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression from #113065
The PR removed a call to update tabs, because the editor does it in
_update_theme()and I wrongly though that it happens when the style setting is changed. It doesn't, only Output dock was updating, because it likes to update a lot.