Skip to content

Use new dock system for Debugger - #113133

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
lodetrick:debugger-dock
Nov 27, 2025
Merged

Use new dock system for Debugger#113133
akien-mga merged 1 commit into
godotengine:masterfrom
lodetrick:debugger-dock

Conversation

@lodetrick

@lodetrick lodetrick commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

See #113024

This PR updates the Debugger dock to use the new dock system. I tried to allow it to float but couldn't find a good way to avoid the EditorDebuggerSession from self-disconnecting because it thought the debugger was deleted.

The issue:
https://github.com/godotengine/godot/blame/369afc7b46d87dd28fc70976fc66875e76e36101/editor/debugger/editor_debugger_plugin.cpp#L124-L135

@lodetrick
lodetrick requested a review from a team as a code owner November 25, 2025 00:25
@lodetrick
lodetrick requested a review from a team November 25, 2025 00:25
@Repiteo Repiteo added this to the 4.x milestone Nov 25, 2025
@KoBeWi

KoBeWi commented Nov 25, 2025

Copy link
Copy Markdown
Member

Note that this requires #113065
The icon should be forced in text-only mode when it shows error.

@lodetrick
lodetrick force-pushed the debugger-dock branch 2 times, most recently from 2f9d0c4 to bff1086 Compare November 25, 2025 21:40
Comment thread editor/debugger/editor_debugger_node.cpp Outdated
Comment thread editor/debugger/editor_debugger_node.h Outdated
Comment thread editor/debugger/script_editor_debugger.cpp Outdated
Comment thread editor/debugger/editor_debugger_node.cpp Outdated
@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Nov 26, 2025
@akien-mga
akien-mga merged commit 30f1ab1 into godotengine:master Nov 27, 2025
20 checks passed
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
wangshucheng pushed a commit to wangshucheng/godot that referenced this pull request Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants