Skip to content

Allow debugger dock to float - #115390

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Open-Industry-Project:float-debugger
Apr 1, 2026
Merged

Allow debugger dock to float#115390
Repiteo merged 1 commit into
godotengine:masterfrom
Open-Industry-Project:float-debugger

Conversation

@ryevdokimov

@ryevdokimov ryevdokimov commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

#113133 added the debugger to the new dock system but disabled the ability to float due to the debugger being set to nullptr on exiting the tree, which happens during a reparent (which happens when making the dock float).

I don't really see the purpose of _debugger_gone_away(). There isn't a way to remove it under any normal conditions that I can find, and if something were to be implemented for some reason, it probably shouldn't be done via the tree exiting due to the things mentioned above that trigger tree_exited.

bugsquad edit:

@ryevdokimov
ryevdokimov requested a review from a team as a code owner January 26, 2026 14:21
@AThousandShips AThousandShips added this to the 4.x milestone Jan 27, 2026
@KoBeWi

KoBeWi commented Feb 3, 2026

Copy link
Copy Markdown
Member

The Debugger dock could be now global (remove set_global(false)).

@KoBeWi

KoBeWi commented Feb 3, 2026

Copy link
Copy Markdown
Member

_debugger_gone_away() was added in #66938
CC @Faless

Comment thread editor/debugger/editor_debugger_node.cpp Outdated
@Repiteo
Repiteo requested a review from a team as a code owner February 17, 2026 20:09

@kitbdev kitbdev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected.
Code looks good, I don't see why _debugger_gone_away would be needed, it gets cleaned up on the destructor. Reparenting the debugger while it is running doesn't cause issues either.

It is currently possible to move the debugger to the additional bottom docks which causes Plugin is not attached to debugger. errors, so this has become a bugfix.

@kitbdev kitbdev added bug and removed enhancement labels Mar 27, 2026
@kitbdev kitbdev modified the milestones: 4.x, 4.7 Mar 27, 2026
@Repiteo
Repiteo merged commit 480350c into godotengine:master Apr 1, 2026
20 checks passed
@Repiteo

Repiteo commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@ryevdokimov
ryevdokimov deleted the float-debugger branch April 1, 2026 18:10
@Naros

Naros commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

@KoBeWi it seems in 4.7-dev4 on Linux, this PR causes the editor to crash when closed/project reloaded. Reverting this PR change and the editor works again. I haven't looked into it, but thought I'd report its not working as expected.

@KoBeWi

KoBeWi commented Apr 12, 2026

Copy link
Copy Markdown
Member

Can't reproduce on Windows. Open a new issue.

@Naros

Naros commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

@KoBeWi done, #118518

BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
wangshucheng pushed a commit to wangshucheng/godot that referenced this pull request Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error "Plugin is not attached to debugger" when alt-tabbing the editor after placing the Debugger into a most bottom dock

6 participants