Allow debugger dock to float - #115390
Conversation
|
The Debugger dock could be now global (remove |
26b834e to
ddae75a
Compare
ddae75a to
658a237
Compare
kitbdev
left a comment
There was a problem hiding this comment.
Tested, works as expected.
Code looks good, I don't see why _debugger_gone_away would be needed, it gets cleaned up on the destructor. Reparenting the debugger while it is running doesn't cause issues either.
It is currently possible to move the debugger to the additional bottom docks which causes Plugin is not attached to debugger. errors, so this has become a bugfix.
|
Thanks! |
|
@KoBeWi it seems in 4.7-dev4 on Linux, this PR causes the editor to crash when closed/project reloaded. Reverting this PR change and the editor works again. I haven't looked into it, but thought I'd report its not working as expected. |
|
Can't reproduce on Windows. Open a new issue. |
Allow debugger dock to float
Allow debugger dock to float
#113133 added the debugger to the new dock system but disabled the ability to float due to the debugger being set to nullptr on exiting the tree, which happens during a reparent (which happens when making the dock float).
I don't really see the purpose of
_debugger_gone_away(). There isn't a way to remove it under any normal conditions that I can find, and if something were to be implemented for some reason, it probably shouldn't be done via the tree exiting due to the things mentioned above that triggertree_exited.bugsquad edit: