Skip to content

Conversation

@sfc-gh-ddas
Copy link
Contributor

@sfc-gh-ddas sfc-gh-ddas commented Nov 24, 2025

SNOW-2236576: Transitive service account impersonation
Added body for POST requests in HTTP Client

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.50%. Comparing base (b29a564) to head (a36bc18).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cpp/http/HttpClient.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   79.51%   79.50%   -0.01%     
==========================================
  Files         127      127              
  Lines       10870    10882      +12     
==========================================
+ Hits         8643     8652       +9     
- Misses       2227     2230       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-ddas sfc-gh-ddas changed the title feature: Add request body for HTTP client Request body param for HTTP client Nov 24, 2025
@sfc-gh-ddas sfc-gh-ddas marked this pull request as ready for review November 24, 2025 10:16
@sfc-gh-ddas sfc-gh-ddas requested a review from a team as a code owner November 24, 2025 10:16
Copy link
Contributor

@sfc-gh-makowalski sfc-gh-makowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we write a unit test for it? I see that the change is really minor here but still.

@sfc-gh-ddas
Copy link
Contributor Author

Shouldn't we write a unit test for it? I see that the change is really minor here but still.

I agree. However, since this is a small change and there isn't an existing test structure for the HTTP client, I feel it is outside of the scope of these tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants