Skip to content

Conversation

@sfc-gh-ddas
Copy link
Contributor

@sfc-gh-ddas sfc-gh-ddas commented Nov 24, 2025

SNOW-2236576 | SNOW-2236579: Transitive service account impersonation

Added support for service account impersonation using comma separated delegation chain for AWS.

The change was based off logic in JDBC equivalent and tested using unit tests with a mock HTTP client.

Depends on #950 and #949

@sfc-gh-ddas sfc-gh-ddas requested a review from a team as a code owner November 24, 2025 15:37
@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2236576/aws-wif-impersonation branch from 3904f3f to 6f9b57d Compare November 24, 2025 16:12
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 40.95745% with 111 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.79%. Comparing base (b29a564) to head (498e431).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cpp/GcpAttestation.cpp 12.03% 95 Missing ⚠️
cpp/AwsAttestation.cpp 85.33% 11 Missing ⚠️
cpp/http/HttpClient.cpp 0.00% 3 Missing ⚠️
cpp/AzureAttestation.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   79.51%   78.79%   -0.72%     
==========================================
  Files         127      127              
  Lines       10870    11055     +185     
==========================================
+ Hits         8643     8711      +68     
- Misses       2227     2344     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2236576/aws-wif-impersonation branch from 6f9b57d to 498e431 Compare November 26, 2025 14:50
@sfc-gh-ddas sfc-gh-ddas changed the title AWS WIF impersonation AWS WIF impersonation (LibSFC) Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants