Skip to content

Conversation

@sfc-gh-ddas
Copy link
Contributor

@sfc-gh-ddas sfc-gh-ddas commented Nov 20, 2025

SNOW-2236576 | SNOW-2236579: Transitive service account impersonation

Added support for service account impersonation using comma separated delegation chain for GCP.

The change was based off logic in JDBC equivalent and tested using unit tests with a mock HTTP client.

Depends on #950

@sfc-gh-ddas sfc-gh-ddas requested a review from a team as a code owner November 20, 2025 13:48
@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2236576/gcp-wif-impersonation branch 2 times, most recently from 4db9f9a to 3ffbf04 Compare November 20, 2025 15:14
@sfc-gh-ddas sfc-gh-ddas changed the title Snow 2236576/gcp wif impersonation GCP WIF impersonation Nov 20, 2025
@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2236576/gcp-wif-impersonation branch from 3ffbf04 to 40eca7e Compare November 24, 2025 00:14
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 11.30435% with 102 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.85%. Comparing base (b29a564) to head (1beee8f).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cpp/GcpAttestation.cpp 12.03% 95 Missing ⚠️
cpp/http/HttpClient.cpp 0.00% 3 Missing ⚠️
cpp/AwsAttestation.cpp 0.00% 2 Missing ⚠️
cpp/AzureAttestation.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   79.51%   78.85%   -0.66%     
==========================================
  Files         127      127              
  Lines       10870    11016     +146     
==========================================
+ Hits         8643     8687      +44     
- Misses       2227     2329     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2236576/gcp-wif-impersonation branch from 74ab524 to 1beee8f Compare November 26, 2025 14:45
@sfc-gh-ddas sfc-gh-ddas changed the title GCP WIF impersonation GCP WIF impersonation (LibSFC) Nov 27, 2025
@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2236576/gcp-wif-impersonation branch from 1beee8f to ef0701c Compare December 2, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants