Skip to content

Conversation

@tea-party-bot
Copy link
Collaborator

@tea-party-bot tea-party-bot commented Oct 20, 2025

Translations update from Weblate for Class Theme for JSON Resume/Copy.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • New Features
    • Added Norwegian, Dutch, Bosnian and Polish language support with UI translations.
    • Localizations cover UI labels, CV sections, contact fields, avatar/title strings and dynamic placeholders to improve the localized user experience.

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

Walkthrough

Added new localization resources for Norwegian (nb-NO), Dutch (nl), and Bosnian (bs), and updated Polish (pl) translations; all changes are static i18n key-value entries for UI and CV-related labels, including a few dynamic placeholders.

Changes

Cohort / File(s) Summary
New locale files
src/i18n/locales/nb-NO.ftl, src/i18n/locales/nl.ftl, src/i18n/locales/bs.ftl
Added new locale resource files containing key-value translation entries for UI and curriculum-vitae labels (e.g., title, curriculum-vitae, contact, website, email, phone, about, work-experience, education, skills, languages, references).
Polish locale update
src/i18n/locales/pl.ftl
Updated/added three Polish entries: title ("{ $name } - CV"), avatar-description ("Zdjęcie profilowe { $name }."), and curriculum-vitae ("CV").

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🐰
I nibbled through keys, tidy and small,
Norwegian, Dutch, Bosnian — I added them all.
A Polish tweak hugged the name just right,
Strings in place now — hop, glow, and delight! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Translations update from Weblate" directly and accurately describes the main change in the changeset, which adds and updates multiple localization files (Norwegian, Dutch, Bosnian, and Polish). The title is concise, clear, and specific enough that a teammate scanning the history would immediately understand this is a translation-related update sourced from Weblate. The title avoids vague language and file noise while remaining readable and immediately meaningful.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch i18n

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5742a52 and 62ad265.

📒 Files selected for processing (4)
  • src/i18n/locales/bs.ftl (1 hunks)
  • src/i18n/locales/nb-NO.ftl (1 hunks)
  • src/i18n/locales/nl.ftl (1 hunks)
  • src/i18n/locales/pl.ftl (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/i18n/locales/nl.ftl
  • src/i18n/locales/nb-NO.ftl
🔇 Additional comments (2)
src/i18n/locales/pl.ftl (1)

1-3: LGTM! Polish translations added correctly.

The Fluent syntax is correct, placeholders are properly formatted, and the translation keys align with the localization structure.

src/i18n/locales/bs.ftl (1)

1-8: LGTM! Bosnian translations added correctly.

The Fluent syntax is correct, placeholders are properly formatted, and all translation keys follow the expected localization structure.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43e014a and 963d026.

📒 Files selected for processing (2)
  • src/i18n/locales/nb-NO.ftl (1 hunks)
  • src/i18n/locales/nl.ftl (1 hunks)
🔇 Additional comments (1)
src/i18n/locales/nl.ftl (1)

1-18: Dutch locale file is correctly implemented—Norwegian inconsistency is a separate issue.

The Dutch localization file (nl.ftl) is properly implemented with all 18 translation keys, matching the English locale exactly. The identified inconsistency with the Norwegian locale (nb-NO.ftl missing avatar-description, dissertation, and present) is confirmed but represents a gap in the Norwegian translations, not a defect in this PR's changes.

@SethFalco SethFalco merged commit e6ec304 into main Oct 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants