-
Notifications
You must be signed in to change notification settings - Fork 10
Translations update from Weblate #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently translated at 83.3% (15 of 18 strings) Translation: Class Theme for JSON Resume/Copy Translate-URL: https://i18n.falco.fun/projects/class-theme-for-json-resume/copy/bs/
Currently translated at 100.0% (18 of 18 strings) Translation: Class Theme for JSON Resume/Copy Translate-URL: https://i18n.falco.fun/projects/class-theme-for-json-resume/copy/pl/
WalkthroughAdds localization keys to Bosnian and Polish locale files, extending translations for resume sections including projects, education, dissertation, skills, languages, interests, and references. No modifications to existing keys or application logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes These are straightforward localization string additions with no logic changes or control flow modifications. The changes follow a consistent, repetitive pattern across both locale files, making them low-complexity edits that are quick to verify for correctness and completeness. Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/i18n/locales/bs.ftl (1)
9-15: LGTM! Bosnian translations look good.The new localization keys are properly formatted with correct Fluent syntax. The
dissertationkey correctly uses the{ $text }variable, consistent with the Polish locale.Consider verifying that all locales have complete coverage of keys for consistency. For example, the Polish locale includes a
presentkey (line 18 in pl.ftl) that could be added to the Bosnian locale as well if applicable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/i18n/locales/bs.ftl(1 hunks)src/i18n/locales/pl.ftl(1 hunks)
🔇 Additional comments (1)
src/i18n/locales/pl.ftl (1)
4-18: LGTM! Polish translations look good.The new localization keys are properly formatted with correct Fluent syntax. The
dissertationkey correctly uses the{ $text }variable, and all keys follow consistent kebab-case naming conventions.
Translations update from Weblate for Class Theme for JSON Resume/Copy.
Current translation status:
Summary by CodeRabbit
Release Notes