Skip to content

Add in-browser prompt to import Google Passwords #6290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jun 25, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1210270953487596?focus=true

Description

Adds ability to show a prompt offering to import passwords from Google at a time when it's most useful to the user: when they've hit a login form and they haven't imported before.

Steps to test this PR

Soft-Dismiss scenarios

  • Tap on the ✖️ button to dismiss it [dismiss count == 1]; verify it dismisses
  • Tap on password field; verify it doesn't show again (it shouldn't show more than once on a page load)
  • Refresh the page and tap on username field again; verify the dialog shows again
  • Tap the back button [dismiss count == 2]; verify the dialog dismisses
  • Tap on password field; verify it doesn't show again (it shouldn't show more than once on a page load)
  • Refresh the page and tap on username field again; verify the dialog shows again
  • Tap outside the dialog [dismiss count == 3]; verify the dialog dismisses
  • Refresh the page and tap on username field again; verify the dialog shows again
  • Tap the ✖️ button again [dismiss count == 4]
  • Refresh the page and tap on username field again; verify the dialog shows again
  • Tap the ✖️ button again [dismiss count == 5]
  • Refresh the page and tap on username field again; verify the dialog shows again
  • Tap the ✖️ button again [dismiss count == 6]
  • Refresh the page and tap on username field again; verify the dialog does not show again

Hard-Dismiss scenario

  • Fresh install from this branch (or use the autofill dev setting called Previous Google Imports to clear previous knowledge of the import dialogs)
  • Visit https://fill.dev/form/login-simple
  • Tap on username field; verify you see the dialog letting you import Google passwords
  • Tap on Set Up Later in Settings button; verify the dialog dismisses
  • Refresh the page and tap on username field again; verify the dialog does not show again

Site already has credentials

  • Fresh install from this branch (or use the autofill dev setting called Previous Google Imports to clear previous knowledge of the import dialogs)
  • Manually add a login credential for fill.dev in the autofill management screen
  • Visit https://fill.dev/form/login-simple
  • Decline to autofill
  • Tap on username field; verify you are not prompted to import passwords

Completing import scenario

  • Add a password for fill.dev to your Google Passwords; instructions for doing so can be found here
  • Fresh install from this branch
  • Visit https://fill.dev/form/login-simple
  • Tap on username field; tap Import From Google button and complete the import flow
  • Verify you see the import success dialog showing how many credentials were imported
  • Dismiss that dialog (doesn't matter how). Verify you are then prompted to autofill with the new credential it just imported and that autofilling works if you agree to do it.

Already imported scenario

  • Fresh install from this branch
  • Visit Settings -> Passwords & Autofill and tap on Import Passwords from Google button
  • Complete the import
  • Visit password list and delete any credentials for fill.dev (having a saved password for that site is not the scenario we want to test here)
  • Visit https://fill.dev/form/login-simple
  • Tap on username field; verify you do not see the dialog letting you import Google passwords

Feature flag disabled scenario

  • Fresh install from this branch
  • Visit FF inventory and disable canPromoteImportGooglePasswordsInBrowser
  • Visit https://fill.dev/form/login-simple
  • Tap on username field; verify you do not see the import password dialog

@CDRussell CDRussell changed the base branch from feature/craig/promo_import_add_icon_to_promo_cta_button to graphite-base/6290 June 25, 2025 14:59
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from f5689bd to a22890e Compare June 25, 2025 14:59
@CDRussell CDRussell changed the base branch from graphite-base/6290 to feature/craig/promo_import_rename_feature_flag_name June 25, 2025 14:59
@CDRussell CDRussell force-pushed the feature/craig/promo_import_rename_feature_flag_name branch from a036140 to 6cacbe2 Compare June 26, 2025 14:00
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from a22890e to 52cd281 Compare June 26, 2025 14:00
@CDRussell CDRussell changed the base branch from feature/craig/promo_import_rename_feature_flag_name to graphite-base/6290 June 27, 2025 12:35
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 52cd281 to 4863459 Compare June 27, 2025 12:35
@CDRussell CDRussell changed the base branch from graphite-base/6290 to feature/craig/autofill/promo_import_cta_design_changes June 27, 2025 12:35
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_cta_design_changes branch from e3f4138 to dd71734 Compare June 27, 2025 13:07
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 4863459 to 43b93f4 Compare June 27, 2025 13:07
@CDRussell CDRussell changed the base branch from feature/craig/autofill/promo_import_cta_design_changes to graphite-base/6290 June 27, 2025 15:42
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 43b93f4 to bda8bef Compare June 27, 2025 15:42
@CDRussell CDRussell changed the base branch from graphite-base/6290 to feature/craig/autofill/promo_import_dev_settings June 27, 2025 15:43
@CDRussell CDRussell changed the base branch from feature/craig/autofill/promo_import_dev_settings to graphite-base/6290 June 30, 2025 13:17
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from bda8bef to 71e5d5f Compare June 30, 2025 13:17
@CDRussell CDRussell changed the base branch from graphite-base/6290 to feature/craig/promo_import_line_break_promo_title June 30, 2025 13:17
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 71e5d5f to c7e7a8d Compare July 1, 2025 10:38
@CDRussell CDRussell force-pushed the feature/craig/promo_import_line_break_promo_title branch from 66662cf to f132877 Compare July 1, 2025 10:38
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from c7e7a8d to 83f635f Compare July 1, 2025 10:50
@CDRussell CDRussell force-pushed the feature/craig/promo_import_line_break_promo_title branch from f132877 to 5592834 Compare July 1, 2025 10:50
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch 11 times, most recently from 094da2c to 459e31e Compare July 9, 2025 17:42
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 459e31e to a3d2d64 Compare July 10, 2025 13:40
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch 4 times, most recently from 3ad027b to 349562d Compare July 14, 2025 14:25
package.json Outdated
@@ -14,7 +14,7 @@
},
"dependencies": {
"@duckduckgo/autoconsent": "^14.3.0",
"@duckduckgo/autofill": "github:duckduckgo/duckduckgo-autofill#18.1.0",
"@duckduckgo/autofill": "github:duckduckgo/duckduckgo-autofill#dbajpeyi/fix/autoprompt-credentials-import",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on stable release; expected imminently

@CDRussell CDRussell marked this pull request as ready for review July 14, 2025 15:11
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 349562d to 22b2efd Compare July 14, 2025 15:11
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

just a few comments NITs and one question about capability checks related with reported bug

@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 22b2efd to e29b24b Compare July 16, 2025 10:38
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from cb18132 to 6807769 Compare July 16, 2025 11:46
@CDRussell CDRussell force-pushed the feature/craig/promo_import_in_browser branch from 6807769 to 7fb8faa Compare July 16, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants