-
Notifications
You must be signed in to change notification settings - Fork 998
Add in-browser prompt to import Google Passwords #6290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CDRussell
wants to merge
4
commits into
develop
Choose a base branch
from
feature/craig/promo_import_in_browser
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,488
−498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2025
This was referenced Jun 25, 2025
f5689bd
to
a22890e
Compare
a036140
to
6cacbe2
Compare
a22890e
to
52cd281
Compare
52cd281
to
4863459
Compare
e3f4138
to
dd71734
Compare
4863459
to
43b93f4
Compare
43b93f4
to
bda8bef
Compare
This was referenced Jun 27, 2025
bda8bef
to
71e5d5f
Compare
71e5d5f
to
c7e7a8d
Compare
66662cf
to
f132877
Compare
c7e7a8d
to
83f635f
Compare
f132877
to
5592834
Compare
094da2c
to
459e31e
Compare
459e31e
to
a3d2d64
Compare
3ad027b
to
349562d
Compare
CDRussell
commented
Jul 14, 2025
package.json
Outdated
@@ -14,7 +14,7 @@ | |||
}, | |||
"dependencies": { | |||
"@duckduckgo/autoconsent": "^14.3.0", | |||
"@duckduckgo/autofill": "github:duckduckgo/duckduckgo-autofill#18.1.0", | |||
"@duckduckgo/autofill": "github:duckduckgo/duckduckgo-autofill#dbajpeyi/fix/autoprompt-credentials-import", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting on stable release; expected imminently
349562d
to
22b2efd
Compare
cmonfortep
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just a few comments NITs and one question about capability checks related with reported bug
.../main/java/com/duckduckgo/autofill/impl/configuration/AutofillAvailableInputTypesProvider.kt
Show resolved
Hide resolved
...l/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/InBrowserImportPromo.kt
Show resolved
Hide resolved
22b2efd
to
e29b24b
Compare
cb18132
to
6807769
Compare
6807769
to
7fb8faa
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1210270953487596?focus=true
Description
Adds ability to show a prompt offering to import passwords from Google at a time when it's most useful to the user: when they've hit a login form and they haven't imported before.
Steps to test this PR
Soft-Dismiss scenarios
Hard-Dismiss scenario
Previous Google Imports
to clear previous knowledge of the import dialogs)Site already has credentials
Previous Google Imports
to clear previous knowledge of the import dialogs)Completing import scenario
Already imported scenario
Settings -> Passwords & Autofill
and tap on Import Passwords from Google buttonFeature flag disabled scenario
canPromoteImportGooglePasswordsInBrowser