Add in-browser prompt to import Google Passwords

Author: CDRussell

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -209,6 +209,8 @@ import com.duckduckgo.autoconsent.api.AutoconsentCallback
 import com.duckduckgo.autofill.api.AutofillCapabilityChecker
 import com.duckduckgo.autofill.api.AutofillEventListener
 import com.duckduckgo.autofill.api.AutofillFragmentResultsPlugin
+import com.duckduckgo.autofill.api.AutofillPrompt
+import com.duckduckgo.autofill.api.AutofillPrompt.ImportPasswords
 import com.duckduckgo.autofill.api.AutofillScreenLaunchSource
 import com.duckduckgo.autofill.api.AutofillScreens.AutofillPasswordsManagementScreenWithSuggestions
 import com.duckduckgo.autofill.api.AutofillScreens.AutofillPasswordsManagementViewCredential
@@ -755,6 +757,20 @@ class BrowserTabFragment :
             viewModel.onShowUserCredentialsSaved(savedCredentials)
         }
 
+        override suspend fun promptUserTo(event: AutofillPrompt) {
+            withContext(dispatchers.main()) {
+                when (event) {
+                    is ImportPasswords -> {
+                        showDialogHidingPrevious(
+                            credentialAutofillDialogFactory.autofillImportPasswordsDialog(tabId),
+                            AUTOFILL_DIALOG_TAB,
+                            event.currentUrl,
+                        )
+                    }
+                }
+            }
+        }
+
         override suspend fun onCredentialsAvailableToSave(
             currentUrl: String,
             credentials: LoginCredentials,
@@ -1769,6 +1785,12 @@ class BrowserTabFragment :
         viewModel.onRefreshRequested(triggeredByUser = false)
     }
 
+    override fun onNewPasswordsImported() {
+        webView?.let {
+            browserAutofill.onNewAutofillDataAvailable()
+        }
+    }
+
     override fun onRejectGeneratedPassword(originalUrl: String) {
         rejectGeneratedPassword(originalUrl)
     }
@@ -3985,6 +4007,7 @@ class BrowserTabFragment :
     }
 
     companion object {
+        private const val AUTOFILL_DIALOG_TAB = "AUTOFILL_DIALOG_TAB"
         private const val CUSTOM_TAB_TOOLBAR_COLOR_ARG = "CUSTOM_TAB_TOOLBAR_COLOR_ARG"
         private const val TAB_DISPLAYED_IN_CUSTOM_TAB_SCREEN_ARG = "TAB_DISPLAYED_IN_CUSTOM_TAB_SCREEN_ARG"
         private const val TAB_ID_ARG = "TAB_ID_ARG"

autofill/autofill-api/src/main/java/com/duckduckgo/autofill/api/AutofillCredentialDialogs.kt

@@ -249,6 +249,11 @@ interface CredentialAutofillDialogFactory {
      * Creates a dialog which prompts the user to sign up for Email Protection
      */
     fun emailProtectionInContextSignUpDialog(tabId: String): DialogFragment
+
+    /**
+     * Creates a dialog which prompts the user to import passwords from Google Passwords
+     */
+    fun autofillImportPasswordsDialog(tabId: String): DialogFragment
 }
 
 private fun prefix(

autofill/autofill-api/src/main/java/com/duckduckgo/autofill/api/AutofillEventListener.kt

@@ -90,4 +90,10 @@ interface AutofillEventListener {
      * Called when a change was detected in the autofill state, such that reloading the page may be necessary.
      */
     fun onAutofillStateChange()
+
+    /**
+     * Called when new passwords are imported.
+     * This can be used to trigger the autofill js flow to re-fetch credentials.
+     */
+    fun onNewPasswordsImported()
 }

autofill/autofill-api/src/main/java/com/duckduckgo/autofill/api/BrowserAutofill.kt

@@ -81,6 +81,11 @@ interface BrowserAutofill {
      * Informs the JS layer that the in-context Email Protection flow has finished
      */
     fun inContextEmailProtectionFlowFinished()
+
+    /**
+     * Informs the JS layer that new autofill data is available, and the JS flow to ask for credentials can start again.
+     */
+    fun onNewAutofillDataAvailable()
 }
 
 /**
@@ -153,4 +158,10 @@ interface Callback {
      * Called when credentials have been saved, and we want to show the user some visual confirmation.
      */
     fun onCredentialsSaved(savedCredentials: LoginCredentials)
+
+    suspend fun promptUserTo(event: AutofillPrompt)
+}
+
+sealed interface AutofillPrompt {
+    data class ImportPasswords(val currentUrl: String) : AutofillPrompt
 }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/AutofillJavascriptInterface.kt

@@ -20,6 +20,7 @@ import android.webkit.JavascriptInterface
 import android.webkit.WebView
 import com.duckduckgo.app.di.AppCoroutineScope
 import com.duckduckgo.autofill.api.AutofillCapabilityChecker
+import com.duckduckgo.autofill.api.AutofillPrompt.ImportPasswords
 import com.duckduckgo.autofill.api.Callback
 import com.duckduckgo.autofill.api.CredentialUpdateExistingCredentialsDialog.CredentialUpdateType
 import com.duckduckgo.autofill.api.EmailProtectionInContextSignupFlowListener
@@ -33,6 +34,7 @@ import com.duckduckgo.autofill.impl.deduper.AutofillLoginDeduplicator
 import com.duckduckgo.autofill.impl.domain.javascript.JavascriptCredentials
 import com.duckduckgo.autofill.impl.email.incontext.availability.EmailProtectionInContextRecentInstallChecker
 import com.duckduckgo.autofill.impl.email.incontext.store.EmailProtectionInContextDataStore
+import com.duckduckgo.autofill.impl.importing.InBrowserImportPromo
 import com.duckduckgo.autofill.impl.jsbridge.AutofillMessagePoster
 import com.duckduckgo.autofill.impl.jsbridge.request.AutofillDataRequest
 import com.duckduckgo.autofill.impl.jsbridge.request.AutofillRequestParser
@@ -72,6 +74,7 @@ import javax.inject.Inject
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
+import logcat.LogPriority.DEBUG
 import logcat.LogPriority.ERROR
 import logcat.LogPriority.INFO
 import logcat.LogPriority.VERBOSE
@@ -110,6 +113,7 @@ interface AutofillJavascriptInterface {
 
     @JavascriptInterface
     fun closeEmailProtectionTab(data: String)
+    fun onNewAutofillDataAvailable()
 }
 
 @ContributesBinding(AppScope::class)
@@ -133,6 +137,7 @@ class AutofillStoredBackJavascriptInterface @Inject constructor(
     private val partialCredentialSaveStore: PartialCredentialSaveStore,
     private val usernameBackFiller: UsernameBackFiller,
     private val existingCredentialMatchDetector: ExistingCredentialMatchDetector,
+    private val inBrowserImportPromo: InBrowserImportPromo,
 ) : AutofillJavascriptInterface {
 
     override var callback: Callback? = null
@@ -147,10 +152,11 @@ class AutofillStoredBackJavascriptInterface @Inject constructor(
     private val storeFormDataJob = ConflatedJob()
     private val injectCredentialsJob = ConflatedJob()
     private val emailProtectionInContextSignupJob = ConflatedJob()
+    private val autofillReloadJob = ConflatedJob()
 
     @JavascriptInterface
     override fun getAutofillData(requestString: String) {
-        logcat(VERBOSE) { "BrowserAutofill: getAutofillData called:\n$requestString" }
+        logcat(DEBUG) { "BrowserAutofill: getAutofillData called:\n$requestString" }
         getAutofillDataJob += coroutineScope.launch(dispatcherProvider.io()) {
             val url = currentUrlProvider.currentUrl(webView)
             if (url == null) {
@@ -186,6 +192,12 @@ class AutofillStoredBackJavascriptInterface @Inject constructor(
         }
     }
 
+    private fun handlePromoteImport(url: String) {
+        coroutineScope.launch {
+            callback?.promptUserTo(ImportPasswords(url))
+        }
+    }
+
     @JavascriptInterface
     override fun getIncontextSignupDismissedAt(data: String) {
         emailProtectionInContextSignupJob += coroutineScope.launch(dispatcherProvider.io()) {
@@ -201,6 +213,14 @@ class AutofillStoredBackJavascriptInterface @Inject constructor(
         emailProtectionInContextSignupFlowCallback?.closeInContextSignup()
     }
 
+    override fun onNewAutofillDataAvailable() {
+        autofillReloadJob += coroutineScope.launch(dispatcherProvider.io()) {
+            val json = autofillResponseWriter.generateResponseNewAutofillDataAvailable()
+            logcat { "import completed; refresh request: $json" }
+            autofillMessagePoster.postMessage(webView, json)
+        }
+    }
+
     @Suppress("UNUSED_PARAMETER")
     @JavascriptInterface
     fun showInContextEmailProtectionSignupPrompt(data: String) {
@@ -246,7 +266,12 @@ class AutofillStoredBackJavascriptInterface @Inject constructor(
         val finalCredentialList = ensureUsernamesNotNull(dedupedCredentials)
 
         if (finalCredentialList.isEmpty()) {
-            callback?.noCredentialsAvailable(url)
+            val canShowImport = inBrowserImportPromo.canShowPromo()
+            if (canShowImport) {
+                handlePromoteImport(url)
+            } else {
+                callback?.noCredentialsAvailable(url)
+            }
         } else {
             callback?.onCredentialsAvailableToInject(url, finalCredentialList, triggerType)
         }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/InlineBrowserAutofill.kt

@@ -79,4 +79,8 @@ class InlineBrowserAutofill @Inject constructor(
     override fun inContextEmailProtectionFlowFinished() {
         autofillInterface.inContextEmailProtectionFlowFinished()
     }
+
+    override fun onNewAutofillDataAvailable() {
+        autofillInterface.onNewAutofillDataAvailable()
+    }
 }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/configuration/AutofillRuntimeConfigProvider.kt

@@ -21,6 +21,7 @@ import com.duckduckgo.autofill.api.AutofillFeature
 import com.duckduckgo.autofill.api.domain.app.LoginCredentials
 import com.duckduckgo.autofill.api.email.EmailManager
 import com.duckduckgo.autofill.impl.email.incontext.availability.EmailProtectionInContextAvailabilityRules
+import com.duckduckgo.autofill.impl.importing.InBrowserImportPromo
 import com.duckduckgo.autofill.impl.jsbridge.response.AvailableInputTypeCredentials
 import com.duckduckgo.autofill.impl.sharedcreds.ShareableCredentials
 import com.duckduckgo.autofill.impl.store.InternalAutofillStore
@@ -49,6 +50,7 @@ class RealAutofillRuntimeConfigProvider @Inject constructor(
     private val emailProtectionInContextAvailabilityRules: EmailProtectionInContextAvailabilityRules,
     private val neverSavedSiteRepository: NeverSavedSiteRepository,
     private val siteSpecificFixesStore: AutofillSiteSpecificFixesStore,
+    private val inBrowserPromo: InBrowserImportPromo,
 ) : AutofillRuntimeConfigProvider {
     override suspend fun getRuntimeConfiguration(
         rawJs: String,
@@ -90,8 +92,9 @@ class RealAutofillRuntimeConfigProvider @Inject constructor(
     private suspend fun generateAvailableInputTypes(url: String?): String {
         val credentialsAvailable = determineIfCredentialsAvailable(url)
         val emailAvailable = determineIfEmailAvailable()
+        val canPromoImport = inBrowserPromo.canShowPromo()
 
-        val json = runtimeConfigurationWriter.generateResponseGetAvailableInputTypes(credentialsAvailable, emailAvailable).also {
+        val json = runtimeConfigurationWriter.generateResponseGetAvailableInputTypes(credentialsAvailable, emailAvailable, canPromoImport).also {
             logcat(VERBOSE) { "autofill-config: availableInputTypes for $url: \n$it" }
         }
         return "availableInputTypes = $json"

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/configuration/RuntimeConfigurationWriter.kt

@@ -28,6 +28,7 @@ interface RuntimeConfigurationWriter {
     fun generateResponseGetAvailableInputTypes(
         credentialsAvailable: AvailableInputTypeCredentials,
         emailAvailable: Boolean,
+        credentialsImport: Boolean,
     ): String
 
     fun generateContentScope(settingsJson: AutofillSiteSpecificFixesSettings): String
@@ -52,8 +53,9 @@ class RealRuntimeConfigurationWriter @Inject constructor(val moshi: Moshi) : Run
     override fun generateResponseGetAvailableInputTypes(
         credentialsAvailable: AvailableInputTypeCredentials,
         emailAvailable: Boolean,
+        credentialsImport: Boolean,
     ): String {
-        val availableInputTypes = AvailableInputSuccessResponse(credentialsAvailable, emailAvailable)
+        val availableInputTypes = AvailableInputSuccessResponse(credentialsAvailable, emailAvailable, credentialsImport)
         return availableInputTypesAdapter.toJson(availableInputTypes)
     }
 

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/InBrowserImportPromo.kt

@@ -0,0 +1,42 @@
+/*
+ * Copyright (c) 2025 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.autofill.impl.importing
+
+import com.duckduckgo.autofill.impl.store.InternalAutofillStore
+import com.duckduckgo.di.scopes.AppScope
+import com.squareup.anvil.annotations.ContributesBinding
+import javax.inject.Inject
+
+interface InBrowserImportPromo {
+    suspend fun canShowPromo(): Boolean
+}
+
+@ContributesBinding(AppScope::class)
+class RealInBrowserImportPromo @Inject constructor(
+    private val autofillStore: InternalAutofillStore,
+) : InBrowserImportPromo {
+
+    override suspend fun canShowPromo(): Boolean {
+        // TODO: stopShowing if:
+        //  user has imported
+        //  has more than 25 login
+        //  more than 5 times shown
+        //  user dismissed
+        //  once per form
+        return autofillStore.hasEverImportedPasswords.not()
+    }
+}

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/ResultHandlerImportPasswords.kt

@@ -0,0 +1,49 @@
+/*
+ * Copyright (c) 2025 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.autofill.impl.importing
+
+import android.content.Context
+import android.os.Bundle
+import androidx.fragment.app.Fragment
+import com.duckduckgo.autofill.api.AutofillEventListener
+import com.duckduckgo.autofill.api.AutofillFragmentResultsPlugin
+import com.duckduckgo.autofill.impl.ui.credential.management.importpassword.google.ImportFromGooglePasswordsDialog.ImportPasswordsDialog
+import com.duckduckgo.di.scopes.AppScope
+import com.squareup.anvil.annotations.ContributesMultibinding
+import javax.inject.Inject
+import logcat.logcat
+
+@ContributesMultibinding(AppScope::class)
+class ResultHandlerImportPasswords @Inject constructor() : AutofillFragmentResultsPlugin {
+
+    override fun processResult(
+        result: Bundle,
+        context: Context,
+        tabId: String,
+        fragment: Fragment,
+        autofillCallback: AutofillEventListener,
+    ) {
+        if (result.getBoolean(ImportPasswordsDialog.KEY_IMPORT_SUCCESS)) {
+            logcat { "Autofill: refresh after import passwords success" }
+            autofillCallback.onNewPasswordsImported()
+        }
+    }
+
+    override fun resultKey(tabId: String): String {
+        return ImportPasswordsDialog.resultKey(tabId)
+    }
+}