Don't show preimport dialog when launching from password import promo

[CDRussell]

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210614808079934?focus=true

Description

Skips showing the "preimport" dialog for Google Import Passwords flow if launched from the import promo.

For context, this is the preimport dialog

Steps to test this PR

• Fresh install
• Visit password management screen
• Manually add a password
• Tap on promo's Open Google Passwords button to import passwords
• Verify you do not see the "preimport" dialog and that the web flow launches ok
• Cancel the flow; verify you do not see the preimport dialog and that you do get returned to the password list
• Tap on promo's Open Google Passwords button again to import passwords
• Complete the flow; verify that you do see the summary bottom sheet showing how many passwords imported
• Delete all passwords
• Tap on the blue Import Passwords From Google button
• Verify that you do see the "preimport" dialog

[CDRussell]

• Add in-browser prompt to import Google Passwords #6290 : 2 dependent PRs (#6368 , #6405 )
• Force line break in import promo title #6317
• Add dev setting for clearing previous google import flag #6311
• Add source to import flow pixels #6310
• Update promo CTA's copy and remove its icon #6307
• Rename feature flag, to allow for separate flags for each password import promo #6293
• Add icon to the import promo's CTA button #6282
• Change requirement for marking a previous password import as having happened #6281
• Don't show preimport dialog when launching from password import promo #6278 👈 (View in Graphite)
• Show import promo in autofill management #6266
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

Implements a flag to skip the introductory import prompt when launching from a promo, and updates the dialog, its ViewModel, call sites, and tests to support a “determining first view” state.

• Introduce showInitialInstructionalPrompt parameter in ImportFromGooglePasswordsDialog and pass it through ViewModel commands
• Add DeterminingFirstView and FlowTerminated states, update UI logic, and adjust existing tests while adding new ones for initial view
• Migrate all call sites to use the new LaunchImportGooglePasswords(showImportInstructions: Boolean) command

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ImportFromGooglePasswordsDialogViewModel.kt	Default viewMode to DeterminingFirstView, add shouldShowInitialInstructionalPrompt and FlowTerminated logic
ImportFromGooglePasswordsDialog.kt	Add showInitialInstructionalPrompt argument, handle DeterminingFirstView/FlowTerminated, move pixel tracking, adjust dialog lifecycle
AutofillSettingsActivity.kt & ListMode classes	Update call sites to pass showInitialInstructionalPrompt into dialog instance
AutofillPasswordsManagementViewModel.kt	Rename command, emit LaunchImportGooglePasswords(showImportInstructions) instead of old command
Test files	Update imports and assertions for new command, add tests for initial view behavior

Comments suppressed due to low confidence (1)

autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/ui/credential/management/importpassword/google/ImportFromGooglePasswordsDialogViewModelTest.kt:115

• Add a test verifying that calling onImportFlowCancelledByUser(stage, canShowPreImportDialog = false) transitions the view state to FlowTerminated so that this branch is covered.

    @Test

[cmonfortep]

LGTM

I pushed a change into the previous PR and I see conflicts here now. I assume restacking them should solve it.

[CDRussell]

Merge activity

• Jul 2, 9:09 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 2, 9:11 AM UTC: Graphite rebased this pull request as part of a merge.
• Jul 2, 9:25 AM UTC: @CDRussell merged this pull request with Graphite.