-
Notifications
You must be signed in to change notification settings - Fork 164
FEAT: Added a new class to customize Page Ports and added 2 new properties #6374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for getter and setter: microwave_port to change the visualization of the port and the reference node.
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6374 +/- ##
==========================================
- Coverage 85.39% 85.37% -0.02%
==========================================
Files 175 175
Lines 66157 66158 +1
==========================================
- Hits 56492 56483 -9
- Misses 9665 9675 +10 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left minor comments
do not merge i am testing / debugging @SMoraisAnsys @maxcapodi78 |
Hi @maxcapodi78 @gkorompi I had to refactor this PR because it already exist a Excitations class. I moved it to the corresponding file, and I think now it behaves as expected, please test it with the workflow you want to implement, just in case I broke something. |
Added a new class to customize Page Ports and added 2 new properties.
With getter and setter:
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Clsoe #6323
Checklist