Skip to content

FEAT: Added a new class to customize Page Ports and added 2 new properties #6374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 14, 2025

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Jul 9, 2025

Added a new class to customize Page Ports and added 2 new properties.
With getter and setter:

  • microwave_port to change the visualization of the port
  • reference node.

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Clsoe #6323

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

…for getter and setter:

microwave_port to change the visualization of the port and the reference node.
@maxcapodi78 maxcapodi78 requested a review from gkorompi July 9, 2025 12:42
@maxcapodi78 maxcapodi78 requested a review from a team as a code owner July 9, 2025 12:43
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 89.53975% with 25 lines in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (6d6d39f) to head (5c3672b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6374      +/-   ##
==========================================
- Coverage   85.39%   85.37%   -0.02%     
==========================================
  Files         175      175              
  Lines       66157    66158       +1     
==========================================
- Hits        56492    56483       -9     
- Misses       9665     9675      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Jul 9, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments

@gkorompi
Copy link
Contributor

gkorompi commented Jul 10, 2025

do not merge i am testing / debugging @SMoraisAnsys @maxcapodi78

@Samuelopez-ansys
Copy link
Member

Hi @maxcapodi78 @gkorompi I had to refactor this PR because it already exist a Excitations class. I moved it to the corresponding file, and I think now it behaves as expected, please test it with the workflow you want to implement, just in case I broke something.

@maxcapodi78 maxcapodi78 merged commit efbe7ca into main Jul 14, 2025
37 checks passed
@maxcapodi78 maxcapodi78 deleted the add_port_reference branch July 14, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants