Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 11-100
13 tasks
qbisi
force-pushed
the
vtk-9.5
branch
2 times, most recently
from
4a22fa1 to
101ab03
Compare
13 tasks
qbisi
force-pushed
the
vtk-9.5
branch
9 times, most recently
from
42ab35b to
bf098e7
Compare
Contributor
Author
|
Contributor
Author
|
@K900 when running test with xvfb backend, it complains you can valid this by runing Does xvfb backend has an optional opengl support that i can enable it in headlessDisplayHook. |
Contributor
|
Can we skip that one test instead? Or is it all of them? |
Contributor
Author
|
Saddly nearly half of the tests (1500+) require x server backend with opengl support. |
Contributor
|
Then we just have to skip those I think, because there's no OpenGL in the sandbox. |
Contributor
Author
|
vtk and pyvista do their headless check on ubuntu server with xvfb backend, is nixpkgs#xvfb diff from that xvfb in debian/ubuntu in lacking opengl support? |
Contributor
|
That's not the problem, the problem is that it's trying to explicitly specify a hardware render device when we're trying to force it to software. I don't think Weston will help here. |
Contributor
Author
|
I have checked with the weston xwayland backend in combine with llvmpipe hook, and nealy all the tests passed, only 4 failed(fail reason are given) |
Contributor
|
OK, I guess we need to build xvfb with GLX support for this to work, which is now possible. |
Contributor
Author
I am not familiar with xvfb, swiching --disable-glx to --enable-glx does not yield a success build for xvfb. Waiting for your contribution. |
K900
reviewed
Jul 18, 2025
K900
reviewed
Jul 18, 2025
K900
reviewed
Jul 18, 2025
Contributor
There was a problem hiding this comment.
Is this split actually necessary?
Contributor
Author
There was a problem hiding this comment.
IMO, neccessary to keep multi vtk instance.
some downstream packages (e.g. gdcm) may react slow to vtk api change. While some (e.g. paraview) want's the latest vtk version.
K900
reviewed
Jul 18, 2025
pkgs/top-level/all-packages.nix
Outdated
Contributor
There was a problem hiding this comment.
Can we not have more Qt5 stuff added?
Contributor
Author
There was a problem hiding this comment.
rtabmap, qcsxcad, appcsxcad, elmerfem depend on vtkWithQt5.
I am not familiar with rtabmap, qcsxcad, appcsxcad, but i am sure elmerfem require vtkWithQt5 and does not work with vtkWithQt6.
Contributor
Author
|
nixpkgs-ci
bot
added
the
2.status: merge conflict
nixpkgs-ci
bot
removed
the
2.status: merge conflict
K900
previously requested changes
Jul 27, 2025
qbisi
force-pushed
the
vtk-9.5
branch
4 times, most recently
from
85317a1 to
47556b5
Compare
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
Build failure of pymatgen should be fixed with #429040. |
Contributor
Author
|
@wegank, should we wait for pyvista 0.46? though it seems like will be soon, but no due time are given. pyvista/pyvista#7690 |
Member
Definitely not. |
Contributor
Author
|
| imath | ||
| c-blosc | ||
| unixODBC | ||
| postgresql |
Contributor
There was a problem hiding this comment.
This added quite a few reverse dependencies to postgresql - which is something we'd like to avoid to lower rebuilds for these updates.
Given that it uses libmysqlclient below, I assume this only needs libpq, it should be tried with that instead.
Trying in #439715.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTK introduces deprecated APIs in every minor release. These deprecated APIs are typically removed after two subsequent minor versions, which often leads to compatibility issues for downstream packages. Since VTK currently publishes a new minor version approximately every six months, I plan to start creating separate package variants for each minor release starting from VTK 9.5. I intend to maintain at least three concurrent minor versions of VTK.
changes:
add headlessDisplayHook doing check for vtk. I will maintain the graphical test presonly.optional dependent pr:
dependent pr:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.