Closed
Conversation
github-actions
bot
added
6.topic: python
wegank
added
the
2.status: merge conflict
dotlambda
reviewed
Apr 25, 2025
ofborg
bot
removed
the
2.status: merge conflict
Member
Author
|
Member
Author
|
Member
Author
|
Ready to go on Linux (Darwin may be another story). |
Contributor
Member
Author
It should be fixed by the latest commit which adds |
Member
Author
|
Member
|
Member
Author
|
So, the error on Darwin comes from the vendored copy of |
13 tasks
Contributor
|
generated binary vtkProbeOpenGLVersion in vtk 9.4.2 will fail to find libGL.so unless export LD_LIBRARY_PATH=${lib.getLib ligGL}/lib |
Contributor
|
This patch will work diff --git a/pkgs/development/libraries/vtk/generic.nix b/pkgs/development/libraries/vtk/generic.nix
index 60b7ae238b83..c9a8f7911a2a 100644
--- a/pkgs/development/libraries/vtk/generic.nix
+++ b/pkgs/development/libraries/vtk/generic.nix
@@ -135,6 +135,10 @@ stdenv.mkDerivation {
--subst-var-by VTK_VER "${version}"
'';
+ postFixup = optionalString stdenv.hostPlatform.isLinux ''
+ patchelf --add-rpath ${lib.getLib libGL}/lib $out/lib/libvtkglad.so
+ '';
+
meta = with lib; {
description = "Open source libraries for 3D computer graphics, image processing and visualization";
homepage = "https://www.vtk.org/"; |
wegank
added
the
2.status: merge conflict
Member
|
Superseded by #417613. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous attempt at upgrading to VTK 9.3.x (#354855) seems stalled, so we may as well try updating to latest and pinning breaking packages to the previous nixpkgs version (9.2.6). Also replaces #370734 which is also stalled (and does not pin 9.2.6).
Notepython3Packages.vtkis unfortunately one of the pinned packages due to e.g.pyvistaalthough I did not try very hard to lift this.@MatthewCroughan @wegank @emilazy
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.