Conversation
ofborg
bot
added
10.rebuild-darwin: 11-100
|
|
@nh2 @Wulfsta @broke @bcdarwin I've been recommended to ping you all to see if we can get VTK updated. It seems like your packages are incompatible with VTK 9.3.1, which might just be because the packages need to be updated. Otherwise, let me know if there's a deeper issue with updating VTK, and if we need to have a |
MatthewCroughan
force-pushed
the
mc/update-vtk
branch
from
2111401 to
9d89a7e
Compare
|
I haven't looked into the @emilazy curious if you have any thoughts on this given you changed some Darwin-related compiler warnings settings for this package recently? |
|
@MatthewCroughan 9.4.0 is now out 😑 - might be worth updating this PR? |
|
@bcdarwin 9.4.0 breaks a lot more, so maybe not. |
|
Thanks for working on this one. |
Given that the version bump seems fairly stalled due to OS X build timeouts, seems like this change should be made in a separate PR (assuming the current VTK 9.2.6 is compatible with Qt6?). |
|
I don’t think a timeout on BTW, |
|
FWIW:
|
|
Since |
|
I am in favour of bumping further given the huge number of vendored libraries. However, we may also just be able to devendor |
github-actions
bot
added
10.rebuild-linux: 101-500
|
github-actions
bot
added
the
6.topic: python
|
Probably outside the scope of this PR, but I would be happy to work on some unvendoring following #171934 or #187016, with the caveat that I don't have a Darwin machine to build on so not sure how I'd get that working. (Likewise, I don't love disabling the pydicom tests as I've been trying to enable more tests in the medical imaging ecosystem, but again don't actually use these arches.) |
|
(Again maybe out of scope, but) given that 9.4.0 is already out and that some science packages (elmerfem/pcl) seemingly will be broken by this upgrade, would it make sense to introduce a vtk_9_2 for now and then in a future PR try the 9.3.x -> 9.4.x upgrade? |
|
You can apply for an account on the Darwin community builder to test builds. Or I’m happy to run builds for you if prompted :) I think a lot of the Darwin issues right now are just LLVM 19, though (like when I ran I think we should just bump as high as we can. There’s (a bit under) six months until the release and all the packages in #354855 (comment) are currently failing to build on Hydra anyway. There’s time for upstreams to adapt to the new versions, or someone to patch them, or for us to re‐introduce the old version for ZHF if necessary. There’s also #370734. |
|
|
My main motivation is to fix VTK on darwin, which doesn't build on master: https://hydra.nixos.org/job/nixpkgs/trunk/vtk.aarch64-darwin I'll check if the workaround also applies for VTK 9.2.6, and if so, move the last two commits to a separate PR. |
github-actions
bot
removed
the
6.topic: python
wegank
added
the
2.status: merge conflict
|
Closing in favour of #385080 since that PR at least builds on x64 Linux and updates to a newer VTK. |
5 participants
Things done
Routine update.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.