Skip to content

vtk: fix libGL include dir#368595

Merged
K900 merged 1 commit intoNixOS:masterfrom
bcdarwin:vtk-fix-libgl-include-dir
Jan 9, 2025
Merged

vtk: fix libGL include dir#368595
K900 merged 1 commit intoNixOS:masterfrom
bcdarwin:vtk-fix-libgl-include-dir

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Dec 27, 2024

Previous include dir wasn't correct, as pointed out here.

No-op on Darwin. [update: also looks like vtk is completely broken on Darwin now, probably due to staging-next fallout?]

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 27, 2024
@ofborg ofborg bot requested a review from tfmoraes December 27, 2024 19:02
@bcdarwin bcdarwin force-pushed the vtk-fix-libgl-include-dir branch from b8db371 to 3ef6e71 Compare January 5, 2025 23:29
@github-actions github-actions bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 5, 2025
@K900 K900 merged commit 8e97141 into NixOS:master Jan 9, 2025
@bcdarwin bcdarwin deleted the vtk-fix-libgl-include-dir branch January 9, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants