Skip to content

vtk: add vtk-dicom module#435382

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
bcdarwin:vtk-enable-vtkdicom
Aug 23, 2025
Merged

vtk: add vtk-dicom module#435382
Sigmanificient merged 1 commit intoNixOS:masterfrom
bcdarwin:vtk-enable-vtkdicom

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Aug 20, 2025 •
edited
Loading

Refresh of #317335 by @kurnevsky which was stale and no longer mergeable after #417613. Currently disabled on Darwin as I don't know if it will build or not.

@qbisi I wasn't sure what the criteria for being included in passthru.vtkPackages is but let me know if I should add gdcm/vtk-dicom.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Aug 20, 2025
@nix-owners nix-owners bot requested a review from qbisi August 20, 2025 20:34
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 20, 2025
qbisi
qbisi suggested changes Aug 21, 2025
View reviewed changes
@bcdarwin
Copy link
Member Author

bcdarwin commented Aug 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 435382
Commit: db16c24b9b564c15a8e4c22af549f09ae1a948bb

x86_64-linux

✅ 203 packages built:
  • ants
  • appcsxcad
  • c3d
  • cloudcompare
  • csxcad
  • elastix
  • elmerfem
  • exhibit
  • expliot
  • expliot.dist
  • ezminc
  • f3d
  • f3d.man
  • freecad
  • gdcm
  • intensity-normalization (python313Packages.intensity-normalization)
  • intensity-normalization.dist (python313Packages.intensity-normalization.dist)
  • itk (itk_5)
  • itk_5_2
  • libsForQt5.qcsxcad (plasma5Packages.qcsxcad)
  • libsForQt5.qcsxcad.dev (plasma5Packages.qcsxcad.dev)
  • mirtk
  • mrtrix
  • octavePackages.dicom
  • openems
  • otb
  • paraview
  • pcl
  • python312Packages.dcmstack
  • python312Packages.dcmstack.dist
  • python312Packages.deid
  • python312Packages.deid.dist
  • python312Packages.dicom-numpy
  • python312Packages.dicom-numpy.dist
  • python312Packages.dicom2nifti
  • python312Packages.dicom2nifti.dist
  • python312Packages.dicomweb-client
  • python312Packages.dicomweb-client.dist
  • python312Packages.dipy
  • python312Packages.dipy.dist
  • python312Packages.f3d
  • python312Packages.f3d.man
  • python312Packages.fast-simplification
  • python312Packages.fast-simplification.dist
  • python312Packages.fslpy
  • python312Packages.fslpy.dist
  • python312Packages.gdcm
  • python312Packages.gstools
  • python312Packages.gstools.dist
  • python312Packages.heudiconv
  • python312Packages.heudiconv.dist
  • python312Packages.highdicom
  • python312Packages.highdicom.dist
  • python312Packages.intensity-normalization
  • python312Packages.intensity-normalization.dist
  • python312Packages.itk
  • python312Packages.mayavi
  • python312Packages.mayavi.dist
  • python312Packages.medpy
  • python312Packages.medpy.dist
  • python312Packages.medvol
  • python312Packages.medvol.dist
  • python312Packages.napari-nifti
  • python312Packages.napari-nifti.dist
  • python312Packages.nibabel
  • python312Packages.nibabel.dist
  • python312Packages.nilearn
  • python312Packages.nilearn.dist
  • python312Packages.nipy
  • python312Packages.nipy.dist
  • python312Packages.nipype
  • python312Packages.nipype.dist
  • python312Packages.nitime
  • python312Packages.nitime.dist
  • python312Packages.nitransforms
  • python312Packages.nitransforms.dist
  • python312Packages.niworkflows
  • python312Packages.niworkflows.dist
  • python312Packages.pybids
  • python312Packages.pybids.dist
  • python312Packages.pydicom
  • python312Packages.pydicom.dist
  • python312Packages.pykrige
  • python312Packages.pykrige.dist
  • python312Packages.pylibjpeg
  • python312Packages.pylibjpeg-openjpeg
  • python312Packages.pylibjpeg-openjpeg.dist
  • python312Packages.pylibjpeg.dist
  • python312Packages.pymatgen
  • python312Packages.pymatgen.dist
  • python312Packages.pymedio
  • python312Packages.pymedio.dist
  • python312Packages.pynetdicom
  • python312Packages.pynetdicom.dist
  • python312Packages.pyorthanc
  • python312Packages.pyorthanc.dist
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python312Packages.pyradiomics
  • python312Packages.pyradiomics.dist
  • python312Packages.python-csxcad
  • python312Packages.python-csxcad.dist
  • python312Packages.python-openems
  • python312Packages.python-openems.dist
  • python312Packages.pyvista
  • python312Packages.pyvista.dist
  • python312Packages.sfepy
  • python312Packages.sfepy.dist
  • python312Packages.simpleitk
  • python312Packages.simpleitk.dist
  • python312Packages.sumo
  • python312Packages.sumo.dist
  • python312Packages.templateflow
  • python312Packages.templateflow.dist
  • python312Packages.torchio
  • python312Packages.torchio.dist
  • python312Packages.trx-python
  • python312Packages.trx-python.dist
  • python312Packages.vtk
  • python312Packages.xnatpy
  • python312Packages.xnatpy.dist
  • python313Packages.dcmstack
  • python313Packages.dcmstack.dist
  • python313Packages.deid
  • python313Packages.deid.dist
  • python313Packages.dicom-numpy
  • python313Packages.dicom-numpy.dist
  • python313Packages.dicom2nifti
  • python313Packages.dicom2nifti.dist
  • python313Packages.dicomweb-client
  • python313Packages.dicomweb-client.dist
  • python313Packages.dipy
  • python313Packages.dipy.dist
  • python313Packages.f3d
  • python313Packages.f3d.man
  • python313Packages.fast-simplification
  • python313Packages.fast-simplification.dist
  • python313Packages.fslpy
  • python313Packages.fslpy.dist
  • python313Packages.gdcm
  • python313Packages.gstools
  • python313Packages.gstools.dist
  • python313Packages.highdicom
  • python313Packages.highdicom.dist
  • python313Packages.itk
  • python313Packages.medpy
  • python313Packages.medpy.dist
  • python313Packages.medvol
  • python313Packages.medvol.dist
  • python313Packages.napari-nifti
  • python313Packages.napari-nifti.dist
  • python313Packages.nibabel
  • python313Packages.nibabel.dist
  • python313Packages.nilearn
  • python313Packages.nilearn.dist
  • python313Packages.nipy
  • python313Packages.nipy.dist
  • python313Packages.nitime
  • python313Packages.nitime.dist
  • python313Packages.nitransforms
  • python313Packages.nitransforms.dist
  • python313Packages.pybids
  • python313Packages.pybids.dist
  • python313Packages.pydicom
  • python313Packages.pydicom.dist
  • python313Packages.pykrige
  • python313Packages.pykrige.dist
  • python313Packages.pylibjpeg
  • python313Packages.pylibjpeg-openjpeg
  • python313Packages.pylibjpeg-openjpeg.dist
  • python313Packages.pylibjpeg.dist
  • python313Packages.pymedio
  • python313Packages.pymedio.dist
  • python313Packages.pynetdicom
  • python313Packages.pynetdicom.dist
  • python313Packages.pyorthanc
  • python313Packages.pyorthanc.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
  • python313Packages.pyradiomics
  • python313Packages.pyradiomics.dist
  • python313Packages.python-csxcad
  • python313Packages.python-csxcad.dist
  • python313Packages.pyvista
  • python313Packages.pyvista.dist
  • python313Packages.simpleitk
  • python313Packages.simpleitk.dist
  • python313Packages.templateflow
  • python313Packages.templateflow.dist
  • python313Packages.torchio
  • python313Packages.torchio.dist
  • python313Packages.trx-python
  • python313Packages.trx-python.dist
  • python313Packages.vtk
  • python313Packages.xnatpy
  • python313Packages.xnatpy.dist
  • rtabmap
  • simpleitk
  • therion
  • vtk (vtk_9_5)
  • vtk-full
  • vtkWithQt5
  • vtkWithQt6

@bcdarwin bcdarwin mentioned this pull request Aug 21, 2025
Closed
13 tasks
@bcdarwin bcdarwin force-pushed the vtk-enable-vtkdicom branch from db16c24 to 6cf98bc Compare August 21, 2025 15:00
@bcdarwin bcdarwin force-pushed the vtk-enable-vtkdicom branch from 6cf98bc to ecaa141 Compare August 21, 2025 15:03
@bcdarwin bcdarwin requested a review from qbisi August 21, 2025 15:04
@qbisi
Copy link
Contributor

qbisi commented Aug 21, 2025

Diff LGTM, i will run nixpkgs-review on aarch64-darwin.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 21, 2025
@qbisi
Copy link
Contributor

qbisi commented Aug 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 435382
Commit: ecaa14186f2d6a9f659b6951fc0825fc7df883ab

aarch64-darwin

✅ 43 packages built:
  • ants
  • elmerfem
  • f3d
  • gdcm
  • itk (itk_5)
  • itk_5_2
  • octavePackages.dicom
  • paraview
  • pcl
  • python312Packages.f3d
  • python312Packages.fast-simplification
  • python312Packages.fast-simplification.dist
  • python312Packages.gdcm
  • python312Packages.gstools
  • python312Packages.gstools.dist
  • python312Packages.mayavi
  • python312Packages.mayavi.dist
  • python312Packages.pykrige
  • python312Packages.pykrige.dist
  • python312Packages.pymatgen
  • python312Packages.pymatgen.dist
  • python312Packages.pyvista
  • python312Packages.pyvista.dist
  • python312Packages.sfepy
  • python312Packages.sfepy.dist
  • python312Packages.sumo
  • python312Packages.sumo.dist
  • python312Packages.vtk
  • python313Packages.f3d
  • python313Packages.fast-simplification
  • python313Packages.fast-simplification.dist
  • python313Packages.gdcm
  • python313Packages.gstools
  • python313Packages.gstools.dist
  • python313Packages.pykrige
  • python313Packages.pykrige.dist
  • python313Packages.pyvista
  • python313Packages.pyvista.dist
  • python313Packages.vtk
  • vtk (vtk_9_5)
  • vtk-full
  • vtkWithQt5
  • vtkWithQt6

@qbisi
Copy link
Contributor

qbisi commented Aug 22, 2025

I will have a try to make vtkDicom a standalone package depend on vtk.
c.f. https://sources.debian.org/src/vtk-dicom/0.8.17-1/debian/rules

@bcdarwin
Copy link
Member Author

bcdarwin commented Aug 22, 2025

I will have a try to make vtkDicom a standalone package depend on vtk. c.f. https://sources.debian.org/src/vtk-dicom/0.8.17-1/debian/rules

Sounds good, but are you still OK with this being approved for merge in the meantime? I don't really see any downside to enabling it - it's not disproportionately heavyweight like TBB or Qt support or even like the RTK remote module we enable in ITK.

@qbisi
Copy link
Contributor

qbisi commented Aug 23, 2025

I approve for this pr, however I don't have the authority to commit in nixpkgs. I have asked @NickCao who suggest to make vtkDicom a separate package. Any committer can merge this pr.

@Sigmanificient Sigmanificient merged commit bdafdf5 into NixOS:master Aug 23, 2025
30 of 32 checks passed
@bcdarwin bcdarwin deleted the vtk-enable-vtkdicom branch August 23, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@qbisi qbisi qbisi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcdarwin @qbisi @Sigmanificient @kurnevsky