Merged
Conversation
Member
|
This branch has conflicts... |
knoellle
reviewed
Mar 14, 2026
knoellle
reviewed
Mar 14, 2026
knoellle
reviewed
Apr 15, 2026
oleflb
commented
Apr 17, 2026
oleflb
changed the title
launchHULK to allow running custom binaries
knoellle
previously approved these changes
Apr 18, 2026
github-project-automation
Bot
moved this from Request for Review
to Done
in Development
This was referenced Apr 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? What?
The motivation is to be able to easily run commands inside the hulk container, which has special mounts, libraries and environment variables.
With the
launchHULKscript, this required some shenanigans in order to launch a shell.This PR introduces a 2 service approach:
hulk-runtimeservice, which spawns the container and does nothing (sleeps)hulkservice, which has a dependency onhulk-runtimeand execs into the container to run thehulkbinary.Therefore it is now very simple for users to run custom commands (or a shell) in the container by just running
sudo podman exec -it hulk bashIn this PR I also fixed logging such that the journal can be used again.
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
Describe how to test your changes. (For the reviewer)