Skip to content

Create log directory before writing to it#2443

Merged
knoellle merged 3 commits intoHULKs:mainfrom
knoellle:create-log-dir-before-writing
Apr 22, 2026
Merged

Create log directory before writing to it#2443
knoellle merged 3 commits intoHULKs:mainfrom
knoellle:create-log-dir-before-writing

Conversation

@knoellle
Copy link
Copy Markdown
Member

Why? What?

Fixes an issue introduced in #2280. Since that was merged, the log directory with the timestamp was created after the tees tried to write to it, causing them to emit an error message but no log files being created.

  • Fixes #

ToDo / Known Issues

Ideas for Next Iterations (Not This PR)

How to Test

  • Gammaray a robot with the new launch-hulk script
  • Restart hulk service and see the logs being created correctly

@knoellle knoellle enabled auto-merge April 22, 2026 15:47
Copy link
Copy Markdown
Contributor

@alexschmander alexschmander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knoellle knoellle added this pull request to the merge queue Apr 22, 2026
Merged via the queue into HULKs:main with commit 86b37c8 Apr 22, 2026
7 checks passed
@knoellle knoellle deleted the create-log-dir-before-writing branch April 22, 2026 15:56
@github-project-automation github-project-automation Bot moved this from Review to Done in Development Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants