-
Notifications
You must be signed in to change notification settings - Fork 312
Migrate smoke tests to environment component #9100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1007680
Total [baseline] (8.548 s) : 0, 8547675
Agent [candidate] (996.371 ms) : 0, 996371
Total [candidate] (8.547 s) : 0, 8547253
section iast
Agent [baseline] (1.133 s) : 0, 1132665
Total [baseline] (9.229 s) : 0, 9229357
Agent [candidate] (1.134 s) : 0, 1133937
Total [candidate] (9.219 s) : 0, 9218810
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.621 ms) : 0, 695621
BytebuddyAgent [candidate] (688.198 ms) : 0, 688198
GlobalTracer [baseline] (245.081 ms) : 0, 245081
GlobalTracer [candidate] (241.801 ms) : 0, 241801
AppSec [baseline] (30.417 ms) : 0, 30417
AppSec [candidate] (30.154 ms) : 0, 30154
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (6.042 ms) : 0, 6042
Remote Config [baseline] (684.105 µs) : 0, 684
Remote Config [candidate] (674.359 µs) : 0, 674
Telemetry [baseline] (8.284 ms) : 0, 8284
Telemetry [candidate] (8.176 ms) : 0, 8176
section iast
BytebuddyAgent [baseline] (807.278 ms) : 0, 807278
BytebuddyAgent [candidate] (807.73 ms) : 0, 807730
GlobalTracer [baseline] (232.547 ms) : 0, 232547
GlobalTracer [candidate] (233.326 ms) : 0, 233326
AppSec [baseline] (28.539 ms) : 0, 28539
AppSec [candidate] (31.045 ms) : 0, 31045
Debugger [baseline] (6.727 ms) : 0, 6727
Debugger [candidate] (5.786 ms) : 0, 5786
Remote Config [baseline] (592.252 µs) : 0, 592
Remote Config [candidate] (582.852 µs) : 0, 583
Telemetry [baseline] (8.006 ms) : 0, 8006
Telemetry [candidate] (7.964 ms) : 0, 7964
IAST [baseline] (27.666 ms) : 0, 27666
IAST [candidate] (26.155 ms) : 0, 26155
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.868 ms) : 0, 997868
Total [baseline] (10.619 s) : 0, 10619015
Agent [candidate] (995.848 ms) : 0, 995848
Total [candidate] (10.628 s) : 0, 10628312
section appsec
Agent [baseline] (1.178 s) : 0, 1177753
Total [baseline] (10.783 s) : 0, 10783399
Agent [candidate] (1.176 s) : 0, 1176221
Total [candidate] (10.732 s) : 0, 10732136
section iast
Agent [baseline] (1.138 s) : 0, 1138307
Total [baseline] (10.854 s) : 0, 10854493
Agent [candidate] (1.134 s) : 0, 1133965
Total [candidate] (10.812 s) : 0, 10811741
section profiling
Agent [baseline] (1.247 s) : 0, 1246804
Total [baseline] (11.001 s) : 0, 11000780
Agent [candidate] (1.264 s) : 0, 1264346
Total [candidate] (11.059 s) : 0, 11058603
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.82 ms) : 0, 688820
BytebuddyAgent [candidate] (687.039 ms) : 0, 687039
GlobalTracer [baseline] (242.58 ms) : 0, 242580
GlobalTracer [candidate] (242.344 ms) : 0, 242344
AppSec [baseline] (30.113 ms) : 0, 30113
AppSec [candidate] (30.044 ms) : 0, 30044
Debugger [baseline] (6.052 ms) : 0, 6052
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (684.102 µs) : 0, 684
Remote Config [candidate] (706.133 µs) : 0, 706
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (8.243 ms) : 0, 8243
section appsec
BytebuddyAgent [baseline] (711.452 ms) : 0, 711452
BytebuddyAgent [candidate] (711.087 ms) : 0, 711087
GlobalTracer [baseline] (235.443 ms) : 0, 235443
GlobalTracer [candidate] (235.598 ms) : 0, 235598
AppSec [baseline] (171.71 ms) : 0, 171710
AppSec [candidate] (170.328 ms) : 0, 170328
Debugger [baseline] (5.745 ms) : 0, 5745
Debugger [candidate] (5.778 ms) : 0, 5778
Remote Config [baseline] (613.71 µs) : 0, 614
Remote Config [candidate] (605.874 µs) : 0, 606
Telemetry [baseline] (8.025 ms) : 0, 8025
Telemetry [candidate] (8.109 ms) : 0, 8109
IAST [baseline] (23.319 ms) : 0, 23319
IAST [candidate] (23.271 ms) : 0, 23271
section iast
BytebuddyAgent [baseline] (810.852 ms) : 0, 810852
BytebuddyAgent [candidate] (807.818 ms) : 0, 807818
GlobalTracer [baseline] (233.622 ms) : 0, 233622
GlobalTracer [candidate] (232.767 ms) : 0, 232767
AppSec [baseline] (29.755 ms) : 0, 29755
AppSec [candidate] (28.817 ms) : 0, 28817
Debugger [baseline] (6.75 ms) : 0, 6750
Debugger [candidate] (6.813 ms) : 0, 6813
Remote Config [baseline] (591.372 µs) : 0, 591
Remote Config [candidate] (588.66 µs) : 0, 589
Telemetry [baseline] (8.026 ms) : 0, 8026
Telemetry [candidate] (8.061 ms) : 0, 8061
IAST [baseline] (27.135 ms) : 0, 27135
IAST [candidate] (27.714 ms) : 0, 27714
section profiling
BytebuddyAgent [baseline] (678.658 ms) : 0, 678658
BytebuddyAgent [candidate] (689.331 ms) : 0, 689331
GlobalTracer [baseline] (362.111 ms) : 0, 362111
GlobalTracer [candidate] (365.546 ms) : 0, 365546
AppSec [baseline] (32.402 ms) : 0, 32402
AppSec [candidate] (32.961 ms) : 0, 32961
Debugger [baseline] (12.199 ms) : 0, 12199
Debugger [candidate] (11.345 ms) : 0, 11345
Remote Config [baseline] (653.35 µs) : 0, 653
Remote Config [candidate] (670.569 µs) : 0, 671
Telemetry [baseline] (8.06 ms) : 0, 8060
Telemetry [candidate] (8.941 ms) : 0, 8941
ProfilingAgent [baseline] (103.72 ms) : 0, 103720
ProfilingAgent [candidate] (105.806 ms) : 0, 105806
Profiling [baseline] (103.746 ms) : 0, 103746
Profiling [candidate] (105.83 ms) : 0, 105830
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section baseline
no_agent (4.383 ms) : 4333, 4432
. : milestone, 4383,
iast (9.287 ms) : 9139, 9436
. : milestone, 9287,
iast_FULL (13.788 ms) : 13516, 14059
. : milestone, 13788,
iast_GLOBAL (10.45 ms) : 10268, 10633
. : milestone, 10450,
profiling (8.971 ms) : 8822, 9120
. : milestone, 8971,
tracing (7.414 ms) : 7310, 7518
. : milestone, 7414,
section candidate
no_agent (4.339 ms) : 4284, 4395
. : milestone, 4339,
iast (9.428 ms) : 9273, 9584
. : milestone, 9428,
iast_FULL (13.772 ms) : 13497, 14047
. : milestone, 13772,
iast_GLOBAL (10.403 ms) : 10204, 10602
. : milestone, 10403,
profiling (9.276 ms) : 9132, 9421
. : milestone, 9276,
tracing (7.558 ms) : 7445, 7671
. : milestone, 7558,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section baseline
no_agent (37.338 ms) : 37036, 37640
. : milestone, 37338,
appsec (47.981 ms) : 47544, 48419
. : milestone, 47981,
code_origins (44.793 ms) : 44413, 45172
. : milestone, 44793,
iast (44.775 ms) : 44380, 45169
. : milestone, 44775,
profiling (48.735 ms) : 48260, 49210
. : milestone, 48735,
tracing (42.794 ms) : 42445, 43144
. : milestone, 42794,
section candidate
no_agent (37.554 ms) : 37242, 37865
. : milestone, 37554,
appsec (48.053 ms) : 47619, 48487
. : milestone, 48053,
code_origins (44.963 ms) : 44575, 45350
. : milestone, 44963,
iast (45.799 ms) : 45399, 46199
. : milestone, 45799,
profiling (49.534 ms) : 49047, 50020
. : milestone, 49534,
tracing (43.675 ms) : 43294, 44055
. : milestone, 43675,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.395 ms) : 2346, 2444
. : milestone, 2395,
iast (2.179 ms) : 2117, 2241
. : milestone, 2179,
iast_GLOBAL (2.226 ms) : 2164, 2288
. : milestone, 2226,
profiling (2.021 ms) : 1972, 2071
. : milestone, 2021,
tracing (1.997 ms) : 1949, 2045
. : milestone, 1997,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.401 ms) : 2351, 2450
. : milestone, 2401,
iast (2.183 ms) : 2121, 2245
. : milestone, 2183,
iast_GLOBAL (2.221 ms) : 2158, 2283
. : milestone, 2221,
profiling (2.054 ms) : 2003, 2106
. : milestone, 2054,
tracing (1.993 ms) : 1945, 2040
. : milestone, 1993,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~115d3dcb45, baseline=1.51.0-SNAPSHOT~dd595896c4
dateFormat X
axisFormat %s
section baseline
no_agent (15.159 s) : 15159000, 15159000
. : milestone, 15159000,
appsec (14.842 s) : 14842000, 14842000
. : milestone, 14842000,
iast (18.34 s) : 18340000, 18340000
. : milestone, 18340000,
iast_GLOBAL (18.045 s) : 18045000, 18045000
. : milestone, 18045000,
profiling (15.961 s) : 15961000, 15961000
. : milestone, 15961000,
tracing (14.832 s) : 14832000, 14832000
. : milestone, 14832000,
section candidate
no_agent (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
appsec (14.704 s) : 14704000, 14704000
. : milestone, 14704000,
iast (18.341 s) : 18341000, 18341000
. : milestone, 18341000,
iast_GLOBAL (18.01 s) : 18010000, 18010000
. : milestone, 18010000,
profiling (15.758 s) : 15758000, 15758000
. : milestone, 15758000,
tracing (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
|
4d467d1
to
115d3dc
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (321.262 µs) : 283, 360
. : milestone, 321,
basic (316.082 µs) : 308, 324
. : milestone, 316,
loop (10.979 ms) : 10924, 11034
. : milestone, 10979,
section candidate
noprobe (314.3 µs) : 292, 336
. : milestone, 314,
basic (310.783 µs) : 303, 319
. : milestone, 311,
loop (10.121 ms) : 10100, 10142
. : milestone, 10121,
|
import spock.lang.IgnoreIf | ||
|
||
@IgnoreIf(reason = "Failing on Java 24. Skip until we have a fix.", value = { | ||
Platform.isJavaVersionAtLeast(24) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking does it makes to deprecate Platform
API ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform
will still be use for native image test and capture for now.
You can check its clean up state in #9101
What Does This Do
This PR migrates the internal API to the environment components.
Follow-up to:
Motivation
Additional Notes
This PR is mainly refactoring to use the new methods from the environment component rather than the original ones in
Platform
.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: LANGPLAT-458