-
Notifications
You must be signed in to change notification settings - Fork 312
Clean up Platform and CLIHelper component #9101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.35 ms) : 0, 997350
Total [baseline] (8.564 s) : 0, 8564229
Agent [candidate] (996.397 ms) : 0, 996397
Total [candidate] (8.587 s) : 0, 8586519
section iast
Agent [baseline] (1.137 s) : 0, 1137152
Total [baseline] (9.274 s) : 0, 9273669
Agent [candidate] (1.141 s) : 0, 1141159
Total [candidate] (9.306 s) : 0, 9306284
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.644 ms) : 0, 688644
BytebuddyAgent [candidate] (687.974 ms) : 0, 687974
GlobalTracer [baseline] (241.872 ms) : 0, 241872
GlobalTracer [candidate] (242.595 ms) : 0, 242595
AppSec [baseline] (30.393 ms) : 0, 30393
AppSec [candidate] (30.133 ms) : 0, 30133
Debugger [baseline] (6.068 ms) : 0, 6068
Debugger [candidate] (6.022 ms) : 0, 6022
Remote Config [baseline] (688.492 µs) : 0, 688
Remote Config [candidate] (677.705 µs) : 0, 678
Telemetry [baseline] (8.249 ms) : 0, 8249
Telemetry [candidate] (8.213 ms) : 0, 8213
section iast
BytebuddyAgent [baseline] (811.021 ms) : 0, 811021
BytebuddyAgent [candidate] (813.518 ms) : 0, 813518
GlobalTracer [baseline] (232.991 ms) : 0, 232991
GlobalTracer [candidate] (234.162 ms) : 0, 234162
IAST [baseline] (28.402 ms) : 0, 28402
IAST [candidate] (28.18 ms) : 0, 28180
AppSec [baseline] (27.104 ms) : 0, 27104
AppSec [candidate] (29.815 ms) : 0, 29815
Debugger [baseline] (7.623 ms) : 0, 7623
Debugger [candidate] (5.893 ms) : 0, 5893
Remote Config [baseline] (584.389 µs) : 0, 584
Remote Config [candidate] (585.112 µs) : 0, 585
Telemetry [baseline] (8.079 ms) : 0, 8079
Telemetry [candidate] (8.141 ms) : 0, 8141
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.997 ms) : 0, 996997
Total [baseline] (10.719 s) : 0, 10719330
Agent [candidate] (996.664 ms) : 0, 996664
Total [candidate] (10.649 s) : 0, 10648960
section appsec
Agent [baseline] (1.175 s) : 0, 1174773
Total [baseline] (10.725 s) : 0, 10724504
Agent [candidate] (1.174 s) : 0, 1174373
Total [candidate] (10.699 s) : 0, 10699017
section iast
Agent [baseline] (1.142 s) : 0, 1141740
Total [baseline] (10.944 s) : 0, 10943650
Agent [candidate] (1.135 s) : 0, 1134953
Total [candidate] (10.928 s) : 0, 10928185
section profiling
Agent [baseline] (1.245 s) : 0, 1245136
Total [baseline] (10.98 s) : 0, 10980212
Agent [candidate] (1.245 s) : 0, 1245037
Total [candidate] (11.03 s) : 0, 11029821
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.258 ms) : 0, 688258
BytebuddyAgent [candidate] (688.571 ms) : 0, 688571
GlobalTracer [baseline] (242.275 ms) : 0, 242275
GlobalTracer [candidate] (242.089 ms) : 0, 242089
AppSec [baseline] (30.102 ms) : 0, 30102
AppSec [candidate] (30.32 ms) : 0, 30320
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (668.609 µs) : 0, 669
Remote Config [candidate] (673.31 µs) : 0, 673
Telemetry [baseline] (8.19 ms) : 0, 8190
Telemetry [candidate] (8.214 ms) : 0, 8214
section appsec
BytebuddyAgent [baseline] (710.226 ms) : 0, 710226
BytebuddyAgent [candidate] (709.743 ms) : 0, 709743
GlobalTracer [baseline] (234.93 ms) : 0, 234930
GlobalTracer [candidate] (234.922 ms) : 0, 234922
AppSec [baseline] (170.548 ms) : 0, 170548
AppSec [candidate] (171.242 ms) : 0, 171242
Debugger [baseline] (5.719 ms) : 0, 5719
Debugger [candidate] (5.748 ms) : 0, 5748
Remote Config [baseline] (597.817 µs) : 0, 598
Remote Config [candidate] (598.096 µs) : 0, 598
Telemetry [baseline] (8.006 ms) : 0, 8006
Telemetry [candidate] (8.022 ms) : 0, 8022
IAST [baseline] (23.338 ms) : 0, 23338
IAST [candidate] (23.356 ms) : 0, 23356
section iast
BytebuddyAgent [baseline] (813.317 ms) : 0, 813317
BytebuddyAgent [candidate] (808.37 ms) : 0, 808370
GlobalTracer [baseline] (234.146 ms) : 0, 234146
GlobalTracer [candidate] (233.245 ms) : 0, 233245
AppSec [baseline] (29.086 ms) : 0, 29086
AppSec [candidate] (31.641 ms) : 0, 31641
Debugger [baseline] (6.767 ms) : 0, 6767
Debugger [candidate] (5.848 ms) : 0, 5848
Remote Config [baseline] (597.032 µs) : 0, 597
Remote Config [candidate] (582.661 µs) : 0, 583
Telemetry [baseline] (8.101 ms) : 0, 8101
Telemetry [candidate] (8.092 ms) : 0, 8092
IAST [baseline] (28.214 ms) : 0, 28214
IAST [candidate] (26.311 ms) : 0, 26311
section profiling
ProfilingAgent [baseline] (103.311 ms) : 0, 103311
ProfilingAgent [candidate] (103.609 ms) : 0, 103609
BytebuddyAgent [baseline] (678.85 ms) : 0, 678850
BytebuddyAgent [candidate] (678.832 ms) : 0, 678832
GlobalTracer [baseline] (360.908 ms) : 0, 360908
GlobalTracer [candidate] (360.983 ms) : 0, 360983
AppSec [baseline] (30.877 ms) : 0, 30877
AppSec [candidate] (32.976 ms) : 0, 32976
Debugger [baseline] (13.363 ms) : 0, 13363
Debugger [candidate] (9.967 ms) : 0, 9967
Remote Config [baseline] (663.463 µs) : 0, 663
Remote Config [candidate] (659.01 µs) : 0, 659
Telemetry [baseline] (8.022 ms) : 0, 8022
Telemetry [candidate] (9.519 ms) : 0, 9519
Profiling [baseline] (103.334 ms) : 0, 103334
Profiling [candidate] (103.633 ms) : 0, 103633
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (36.745 ms) : 36443, 37047
. : milestone, 36745,
appsec (46.636 ms) : 46210, 47062
. : milestone, 46636,
code_origins (45.184 ms) : 44785, 45582
. : milestone, 45184,
iast (43.331 ms) : 42956, 43705
. : milestone, 43331,
profiling (49.029 ms) : 48567, 49492
. : milestone, 49029,
tracing (43.937 ms) : 43540, 44334
. : milestone, 43937,
section candidate
no_agent (36.222 ms) : 35935, 36508
. : milestone, 36222,
appsec (45.932 ms) : 45533, 46331
. : milestone, 45932,
code_origins (43.253 ms) : 42881, 43624
. : milestone, 43253,
iast (45.346 ms) : 44947, 45745
. : milestone, 45346,
profiling (45.151 ms) : 44757, 45544
. : milestone, 45151,
tracing (41.866 ms) : 41514, 42218
. : milestone, 41866,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (4.547 ms) : 4495, 4600
. : milestone, 4547,
iast (9.314 ms) : 9154, 9473
. : milestone, 9314,
iast_FULL (14.224 ms) : 13937, 14511
. : milestone, 14224,
iast_GLOBAL (10.595 ms) : 10404, 10787
. : milestone, 10595,
profiling (8.632 ms) : 8493, 8770
. : milestone, 8632,
tracing (7.311 ms) : 7205, 7418
. : milestone, 7311,
section candidate
no_agent (4.49 ms) : 4438, 4542
. : milestone, 4490,
iast (9.088 ms) : 8937, 9240
. : milestone, 9088,
iast_FULL (14.625 ms) : 14332, 14919
. : milestone, 14625,
iast_GLOBAL (10.308 ms) : 10131, 10486
. : milestone, 10308,
profiling (8.816 ms) : 8666, 8966
. : milestone, 8816,
tracing (7.672 ms) : 7562, 7782
. : milestone, 7672,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.393 ms) : 2344, 2441
. : milestone, 2393,
iast (2.179 ms) : 2118, 2241
. : milestone, 2179,
iast_GLOBAL (2.227 ms) : 2165, 2289
. : milestone, 2227,
profiling (2.035 ms) : 1985, 2084
. : milestone, 2035,
tracing (2.002 ms) : 1954, 2050
. : milestone, 2002,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.392 ms) : 2343, 2441
. : milestone, 2392,
iast (2.182 ms) : 2120, 2243
. : milestone, 2182,
iast_GLOBAL (2.224 ms) : 2162, 2286
. : milestone, 2224,
profiling (2.031 ms) : 1980, 2081
. : milestone, 2031,
tracing (2.01 ms) : 1962, 2058
. : milestone, 2010,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~eaf8c40d59, baseline=1.51.0-SNAPSHOT~1de42c8097
dateFormat X
axisFormat %s
section baseline
no_agent (15.787 s) : 15787000, 15787000
. : milestone, 15787000,
appsec (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
iast (18.279 s) : 18279000, 18279000
. : milestone, 18279000,
iast_GLOBAL (18.042 s) : 18042000, 18042000
. : milestone, 18042000,
profiling (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
tracing (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
section candidate
no_agent (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
appsec (14.732 s) : 14732000, 14732000
. : milestone, 14732000,
iast (18.174 s) : 18174000, 18174000
. : milestone, 18174000,
iast_GLOBAL (17.879 s) : 17879000, 17879000
. : milestone, 17879000,
profiling (15.412 s) : 15412000, 15412000
. : milestone, 15412000,
tracing (14.765 s) : 14765000, 14765000
. : milestone, 14765000,
|
4d467d1
to
115d3dc
Compare
721cba2
to
fea3156
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 6 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (318.88 µs) : 284, 354
. : milestone, 319,
basic (309.805 µs) : 302, 318
. : milestone, 310,
loop (10.823 ms) : 10801, 10844
. : milestone, 10823,
section candidate
noprobe (311.244 µs) : 288, 335
. : milestone, 311,
basic (303.612 µs) : 295, 312
. : milestone, 304,
loop (10.174 ms) : 10139, 10208
. : milestone, 10174,
|
fea3156
to
eaf8c40
Compare
What Does This Do
This PR cleans up Platform methods and the original CLIHelper component.
Follow-up to:
Motivation
The behavior moved into the dedicated environment component.
Additional Notes
This should be the last PR for the environment component for now.
Next steps would be to keep porting related features to this component.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: LANGPLAT-458