-
Notifications
You must be signed in to change notification settings - Fork 312
Improve environment component null values handling #9188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+50
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038360
Total [baseline] (8.65 s) : 0, 8649624
Agent [candidate] (1.04 s) : 0, 1039563
Total [candidate] (8.63 s) : 0, 8629599
section iast
Agent [baseline] (1.181 s) : 0, 1181129
Total [baseline] (9.385 s) : 0, 9385418
Agent [candidate] (1.171 s) : 0, 1171258
Total [candidate] (9.311 s) : 0, 9311227
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (729.81 ms) : 0, 729810
BytebuddyAgent [candidate] (730.605 ms) : 0, 730605
GlobalTracer [baseline] (241.056 ms) : 0, 241056
GlobalTracer [candidate] (241.286 ms) : 0, 241286
AppSec [baseline] (30.377 ms) : 0, 30377
AppSec [candidate] (30.421 ms) : 0, 30421
Debugger [baseline] (6.023 ms) : 0, 6023
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (650.757 µs) : 0, 651
Remote Config [candidate] (657.251 µs) : 0, 657
Telemetry [baseline] (8.178 ms) : 0, 8178
Telemetry [candidate] (8.238 ms) : 0, 8238
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (853.57 ms) : 0, 853570
BytebuddyAgent [candidate] (846.381 ms) : 0, 846381
GlobalTracer [baseline] (231.749 ms) : 0, 231749
GlobalTracer [candidate] (230.486 ms) : 0, 230486
IAST [baseline] (29.471 ms) : 0, 29471
IAST [candidate] (30.457 ms) : 0, 30457
AppSec [baseline] (27.661 ms) : 0, 27661
AppSec [candidate] (26.517 ms) : 0, 26517
Debugger [baseline] (7.578 ms) : 0, 7578
Debugger [candidate] (6.661 ms) : 0, 6661
Remote Config [baseline] (603.613 µs) : 0, 604
Remote Config [candidate] (600.504 µs) : 0, 601
Telemetry [baseline] (8.09 ms) : 0, 8090
Telemetry [candidate] (7.953 ms) : 0, 7953
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039448
Total [baseline] (10.683 s) : 0, 10683030
Agent [candidate] (1.042 s) : 0, 1041850
Total [candidate] (10.665 s) : 0, 10664640
section appsec
Agent [baseline] (1.219 s) : 0, 1218613
Total [baseline] (10.776 s) : 0, 10775555
Agent [candidate] (1.215 s) : 0, 1215277
Total [candidate] (10.836 s) : 0, 10835944
section iast
Agent [baseline] (1.173 s) : 0, 1173241
Total [baseline] (10.877 s) : 0, 10876669
Agent [candidate] (1.176 s) : 0, 1175649
Total [candidate] (10.932 s) : 0, 10931802
section profiling
Agent [baseline] (1.186 s) : 0, 1185670
Total [baseline] (10.914 s) : 0, 10914382
Agent [candidate] (1.184 s) : 0, 1183655
Total [candidate] (10.871 s) : 0, 10871165
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (729.922 ms) : 0, 729922
BytebuddyAgent [candidate] (731.647 ms) : 0, 731647
GlobalTracer [baseline] (241.244 ms) : 0, 241244
GlobalTracer [candidate] (241.636 ms) : 0, 241636
AppSec [baseline] (30.353 ms) : 0, 30353
AppSec [candidate] (30.475 ms) : 0, 30475
Debugger [baseline] (5.961 ms) : 0, 5961
Debugger [candidate] (6.024 ms) : 0, 6024
Remote Config [baseline] (645.627 µs) : 0, 646
Remote Config [candidate] (658.082 µs) : 0, 658
Telemetry [baseline] (9.002 ms) : 0, 9002
Telemetry [candidate] (8.982 ms) : 0, 8982
section appsec
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (752.255 ms) : 0, 752255
BytebuddyAgent [candidate] (751.083 ms) : 0, 751083
GlobalTracer [baseline] (234.575 ms) : 0, 234575
GlobalTracer [candidate] (233.747 ms) : 0, 233747
AppSec [baseline] (168.101 ms) : 0, 168101
AppSec [candidate] (169.479 ms) : 0, 169479
Debugger [baseline] (8.676 ms) : 0, 8676
Debugger [candidate] (5.632 ms) : 0, 5632
Remote Config [baseline] (606.95 µs) : 0, 607
Remote Config [candidate] (606.038 µs) : 0, 606
Telemetry [baseline] (8.07 ms) : 0, 8070
Telemetry [candidate] (8.822 ms) : 0, 8822
IAST [baseline] (23.662 ms) : 0, 23662
IAST [candidate] (23.362 ms) : 0, 23362
section iast
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (847.903 ms) : 0, 847903
BytebuddyAgent [candidate] (849.656 ms) : 0, 849656
GlobalTracer [baseline] (231.026 ms) : 0, 231026
GlobalTracer [candidate] (231.728 ms) : 0, 231728
AppSec [baseline] (29.588 ms) : 0, 29588
AppSec [candidate] (27.146 ms) : 0, 27146
Debugger [baseline] (7.346 ms) : 0, 7346
Debugger [candidate] (5.755 ms) : 0, 5755
Remote Config [baseline] (586.938 µs) : 0, 587
Remote Config [candidate] (589.42 µs) : 0, 589
Telemetry [baseline] (7.94 ms) : 0, 7940
Telemetry [candidate] (7.942 ms) : 0, 7942
IAST [baseline] (26.48 ms) : 0, 26480
IAST [candidate] (30.506 ms) : 0, 30506
section profiling
ProfilingAgent [baseline] (104.798 ms) : 0, 104798
ProfilingAgent [candidate] (102.728 ms) : 0, 102728
crashtracking [baseline] (1.397 ms) : 0, 1397
crashtracking [candidate] (1.406 ms) : 0, 1406
BytebuddyAgent [baseline] (759.786 ms) : 0, 759786
BytebuddyAgent [candidate] (759.523 ms) : 0, 759523
GlobalTracer [baseline] (220.259 ms) : 0, 220259
GlobalTracer [candidate] (220.245 ms) : 0, 220245
AppSec [baseline] (30.2 ms) : 0, 30200
AppSec [candidate] (30.386 ms) : 0, 30386
Debugger [baseline] (6.275 ms) : 0, 6275
Debugger [candidate] (6.315 ms) : 0, 6315
Remote Config [baseline] (659.003 µs) : 0, 659
Remote Config [candidate] (671.719 µs) : 0, 672
Telemetry [baseline] (13.951 ms) : 0, 13951
Telemetry [candidate] (14.027 ms) : 0, 14027
Profiling [baseline] (104.821 ms) : 0, 104821
Profiling [candidate] (102.751 ms) : 0, 102751
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (37.617 ms) : 37315, 37918
. : milestone, 37617,
appsec (46.663 ms) : 46252, 47075
. : milestone, 46663,
code_origins (46.191 ms) : 45795, 46586
. : milestone, 46191,
iast (43.891 ms) : 43515, 44268
. : milestone, 43891,
profiling (49.328 ms) : 48834, 49823
. : milestone, 49328,
tracing (44.357 ms) : 43974, 44740
. : milestone, 44357,
section candidate
no_agent (37.643 ms) : 37339, 37947
. : milestone, 37643,
appsec (47.82 ms) : 47393, 48248
. : milestone, 47820,
code_origins (45.897 ms) : 45478, 46317
. : milestone, 45897,
iast (44.333 ms) : 43957, 44710
. : milestone, 44333,
profiling (47.718 ms) : 47274, 48161
. : milestone, 47718,
tracing (41.973 ms) : 41618, 42327
. : milestone, 41973,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (4.494 ms) : 4440, 4549
. : milestone, 4494,
iast (9.399 ms) : 9245, 9552
. : milestone, 9399,
iast_FULL (13.905 ms) : 13630, 14180
. : milestone, 13905,
iast_GLOBAL (10.597 ms) : 10406, 10789
. : milestone, 10597,
profiling (8.858 ms) : 8714, 9003
. : milestone, 8858,
tracing (7.728 ms) : 7614, 7843
. : milestone, 7728,
section candidate
no_agent (4.308 ms) : 4259, 4357
. : milestone, 4308,
iast (9.437 ms) : 9284, 9591
. : milestone, 9437,
iast_FULL (14.182 ms) : 13900, 14463
. : milestone, 14182,
iast_GLOBAL (10.385 ms) : 10196, 10575
. : milestone, 10385,
profiling (8.863 ms) : 8726, 9000
. : milestone, 8863,
tracing (7.653 ms) : 7529, 7777
. : milestone, 7653,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (14.943 s) : 14943000, 14943000
. : milestone, 14943000,
appsec (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
iast (18.362 s) : 18362000, 18362000
. : milestone, 18362000,
iast_GLOBAL (18.311 s) : 18311000, 18311000
. : milestone, 18311000,
profiling (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
tracing (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
section candidate
no_agent (15.509 s) : 15509000, 15509000
. : milestone, 15509000,
appsec (14.804 s) : 14804000, 14804000
. : milestone, 14804000,
iast (18.167 s) : 18167000, 18167000
. : milestone, 18167000,
iast_GLOBAL (18.078 s) : 18078000, 18078000
. : milestone, 18078000,
profiling (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
tracing (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f0fe513bc0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.642 ms) : 3427, 3857
. : milestone, 3642,
iast (2.2 ms) : 2137, 2262
. : milestone, 2200,
iast_GLOBAL (2.241 ms) : 2178, 2303
. : milestone, 2241,
profiling (2.056 ms) : 2005, 2107
. : milestone, 2056,
tracing (2.016 ms) : 1968, 2065
. : milestone, 2016,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.651 ms) : 3435, 3866
. : milestone, 3651,
iast (2.212 ms) : 2149, 2274
. : milestone, 2212,
iast_GLOBAL (2.254 ms) : 2191, 2317
. : milestone, 2254,
profiling (2.49 ms) : 2314, 2666
. : milestone, 2490,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
|
This was referenced Jul 17, 2025
AlexeyKuznetsov-DD
approved these changes
Jul 17, 2025
sarahchen6
approved these changes
Jul 17, 2025
mhlidd
pushed a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: platform
Platform components
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR improves null values handling of environment component.
Motivation
Following feedback on #9170 from @sarahchen6
Additional Notes
Environment component related stacked PRs:
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: LANGPLAT-458