Skip to content

Improve import from Citavi #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve import from Citavi #3426

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2eded18
Citavi Import: Keep line breaks in knowledge items
zuphilip Nov 27, 2023
4057e7c
Citavi Import: Add keywords for knowledge elements
zuphilip Nov 27, 2023
c02aa56
Fix issues from code review
zuphilip Mar 26, 2025
4bc9546
Use .push(...)
AbeJellinek May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions Citavi 5 XML.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"inRepository": true,
"translatorType": 1,
"lastUpdated": "2025-01-04 01:03:00"
"lastUpdated": "2025-03-26 20:00:00"
}

/*
Expand Down Expand Up @@ -174,10 +174,11 @@ async function importItems({ references, doc, citaviVersion, rememberTags, itemI
if (keywords && keywords.length > 0) {
item.tags = attachName(doc, keywords);
}
else {
item.tags = [];
}
if (rememberTags[item.itemID]) {
for (var j = 0; j < rememberTags[item.itemID].length; j++) {
item.tags.push(rememberTags[item.itemID][j]);
}
item.tags.push(...rememberTags[item.itemID]);
}

// For all corresponding knowledge items attach a note containing
Expand All @@ -194,13 +195,21 @@ async function importItems({ references, doc, citaviVersion, rememberTags, itemI
noteObject.note += '<h1>' + title + "</h1>\n";
}
if (text) {
noteObject.note += "<p>" + ZU.xpathText(citations[j], 'Text') + "</p>\n";
text = text.split(/\r?\n/).join("<br />");
noteObject.note += "<p>" + text + "</p>\n";
}
if (pages) {
noteObject.note += "<i>" + pages + "</i>";
}
keywords = ZU.xpathText(doc, '//KnowledgeItemKeywords/OnetoN[starts-with(text(), "' + noteObject.id + '")]');
if (keywords) {
noteObject.tags = attachName(doc, keywords);
}
else {
noteObject.tags = [];
}
if (rememberTags[noteObject.id]) {
noteObject.tags = rememberTags[noteObject.id];
noteObject.tags.push(...rememberTags[noteObject.id]);
}
if (noteObject.note != "") {
item.notes.push(noteObject);
Expand Down Expand Up @@ -466,8 +475,16 @@ function attachName(doc, ids) {
var idList = ids.split(';');
// skip the first element which is the id of reference
for (var j = 1; j < idList.length; j++) {
var author = doc.getElementById(idList[j]);
valueList.push(ZU.xpathText(author, 'Name'));
// sometimes the id is appended by the a (rank?) number,
// which needs to be cleaned first
var id = idList[j].split(":")[0];
var author = doc.getElementById(id);
if (author) {
valueList.push(ZU.xpathText(author, 'Name'));
}
else {
Z.debug("Can't find this id: " + id);
}
}
return valueList;
}
Expand Down
Loading