Improve import from Citavi #3426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing potential problems handling keywords with other tags in general.
zuphilip
force-pushed
the
citavi-nits-2025
branch
from
dab062d to
4057e7c
Compare
AbeJellinek
requested changes
Mar 26, 2025
Citavi 5 XML.js
Outdated
| if (rememberTags[noteObject.id]) { | ||
| noteObject.tags = rememberTags[noteObject.id]; | ||
| for (let j = 0; j < rememberTags[noteObject.id]; j++) { |
There was a problem hiding this comment.
j < rememberTags[noteObject.id] won't work - did you mean to add .length? We should just use for..of here (and elsewhere).
Citavi 5 XML.js
Outdated
| } | ||
| if (pages) { | ||
| noteObject.note += "<i>" + pages + "</i>"; | ||
| } | ||
| keywords = ZU.xpathText(doc, '//KnowledgeItemKeywords/OnetoN[starts-with(text(), "' + noteObject.id + '")]'); | ||
| if (keywords && keywords.length > 0) { |
There was a problem hiding this comment.
Redundant comparison - empty string is falsey
Citavi 5 XML.js
Outdated
| valueList.push(ZU.xpathText(author, 'Name')); | ||
| } | ||
| else { | ||
| Z.debug("Can't find this id:", id); |
There was a problem hiding this comment.
debug() doesn't work like console.log(). Need to concatenate the strings.
|
Thank you for the code review. I fixed all the points. |
AbeJellinek
reviewed
Mar 27, 2025
Citavi 5 XML.js
Outdated
Comment on lines
214
to
216
| for (let tag of rememberTags[noteObject.id]) { | ||
| noteObject.tags.append(tag); | ||
| } |
There was a problem hiding this comment.
There's no array method called append(). push()? Oh, and we can just do this:
Suggested change
| for (let tag of rememberTags[noteObject.id]) { | |
| noteObject.tags.append(tag); | |
| } | |
| noteObject.tags.push(...rememberTags[noteObject.id]); |
And the same above.
|
@zuphilip: I made the update - would you be able to test? I don't have any Citavi data to test with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cherry-pick two small commits from #3183.