chore: add tolkie hooks - #49
Merged
Merged
Conversation
FreakyWizard
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer,
mvdhoek1 and
rivanuff
July 20, 2026 11:00
FreakyWizard
requested review from
JasperS20,
WybeBosch,
Yannicvanveen,
YvetteNikolov and
laravdiemen
and removed request for
a team
July 20, 2026 11:00
FreakyWizard
force-pushed
the
feat/tolkie
branch
from
July 20, 2026 11:01
1135332 to
b3e4f52
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new WordPress hook integration for Tolkie within the brave-components package, conditionally registering the hook when a token is configured.
Changes:
- Introduces
Hooks\Tolkieto inject the Tolkie integration script inwp_footer. - Adds block render filters to append a Tolkie marker element after core heading and post-title blocks.
- Registers the new hook from
ComponentsServiceProviderwhen a Tolkie token is present.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Hooks/Tolkie.php | Adds the footer script tag and block-render marker injection for Tolkie. |
| src/ComponentsServiceProvider.php | Conditionally registers the new Tolkie hook based on a configured token. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ictbeheer
reviewed
Jul 20, 2026
| @@ -37,4 +37,7 @@ | |||
| 'disable' => '', | |||
| 'automaticallyAddToH1' => true, | |||
Contributor
There was a problem hiding this comment.
automaticallyAddToH1 => automatically_add_to_h1 👀
Kunnen we dit nog aanpassen met backwards compatibility
Contributor
Author
There was a problem hiding this comment.
Da was nie mijn aanpassing! Maar wel cool om dat voor Tolkie toe te voegen ja :)
Contributor
Author
There was a problem hiding this comment.
Die van readSpeaker pak ik op in een tweede pr
mvdhoek1
previously approved these changes
Jul 20, 2026
… on page, add default config
mvdhoek1
reviewed
Jul 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zie ook: yardinternet/brave-csp#44