Refactor/readspeaker - #50
Merged
Merged
Conversation
FreakyWizard
requested review from
Rovasch,
ShunLuk,
SimonvanWijhe,
dtakken,
ictbeheer,
mvdhoek1 and
rivanuff
July 20, 2026 12:38
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the ReadSpeaker hook configuration to support a new snake_case config key (with a backwards-compatible fallback) and updates documentation related to Tolkie setup.
Changes:
- Update ReadSpeaker hook to read
components.readSpeaker.automatically_add_to_h1with fallback to legacyautomaticallyAddToH1. - Rename the ReadSpeaker config key in
config/components.phptoautomatically_add_to_h1. - Update README Tolkie instructions to include a CSP allowance step.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Hooks/ReadSpeaker.php | Reads the new config key (with fallback), but currently includes a blocking debug call. |
| config/components.php | Renames ReadSpeaker config key to snake_case. |
| README.md | Adds CSP guidance step for Tolkie usage instructions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laravdiemen
reviewed
Jul 20, 2026
laravdiemen
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#49 (comment)