Skip to content

Build the decks with npm ci so a deploy cannot drift the lockfile #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xmap merged 1 commit into from
Sep 4, 2026
Merged

Build the decks with npm ci so a deploy cannot drift the lockfile #774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Build site
run: mkdocs build --strict

# The decks are slow to build (npm install plus a chromium download per
# The decks are slow to build (npm ci plus a chromium download per
# deck) and nothing deploys from a PR, so skip them there. The mkdocs
# build above is the part a PR needs to prove.
- name: Set up Node
Expand All @@ -102,7 +102,12 @@ jobs:
echo "::group::Building deck: $slug"
(
cd "$dir"
npm install --no-audit --no-fund
# ci, not install: install is free to resolve a newer dependency
# and rewrite the lockfile, so the deck CI deploys would drift
# from the tree. Each deck README already tells a human the same
# thing, because these lockfiles carry linux native-binary
# entries that a resolve on another platform strips.
npm ci --no-audit --no-fund
# Belt-and-suspenders: playwright-chromium's postinstall sometimes
# skips the binary download in CI. Force it before exporting.
npx --yes playwright install chromium
Expand Down
Loading