Build the decks with npm ci so a deploy cannot drift the lockfile - #774
Merged
Conversation
npm install is free to resolve a newer dependency and rewrite package-lock.json during the build, which means a deploy could ship a deck built against a tree that no longer matches what is committed. npm ci installs the lockfile exactly and fails instead if the two have diverged, which is the behaviour a deploy wants. Each deck README already tells a human to use ci rather than install, for a related reason: these lockfiles carry linux native-binary entries that a resolve on another platform strips. CI running the weaker command was the inconsistency. Checked before switching, because ci fails where install would quietly repair: both committed lockfiles resolve cleanly under npm ci --dry-run, and the dry run left them untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
xmap
enabled auto-merge
September 4, 2026 21:21
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm installis free to resolve a newer dependency and rewritepackage-lock.jsonduring the build, so a deploy could ship a deck builtagainst a tree that no longer matches what is committed.
npm ciinstalls thelockfile exactly and fails if the two diverged.
Each deck README already tells a human to use
cirather thaninstall,because these lockfiles carry linux native-binary entries that a resolve on
another platform strips. CI running the weaker command was the inconsistency.
Verified before switching, since
npm cifails wherenpm installquietlyrepairs: both committed lockfiles resolve cleanly under
npm ci --dry-run, andthe dry run left them untouched. The stale
npm installmention in the commentabove the step is updated too.
🤖 Generated with Claude Code