Add unit tests for modules/ipaddresses/ipapi (0% → 83.7% coverage)

modules/ipaddresses/ipapi/settings_test.go

@@ -0,0 +1,119 @@
+package ipapi
+
+import (
+	"testing"
+
+	"github.com/olebedev/config"
+)
+
+func TestNewSettingsFromYAML_Defaults(t *testing.T) {
+	yamlStr := `
+position:
+  top: 0
+  left: 0
+  height: 1
+  width: 1
+`
+	globalStr := `
+wtf:
+  colors:
+    border:
+      focusable: "darkslateblue"
+      focused: "orange"
+      normal: "gray"
+`
+	yamlConfig, err := config.ParseYaml(yamlStr)
+	if err != nil {
+		t.Fatalf("failed to parse yaml: %v", err)
+	}
+	globalConfig, err := config.ParseYaml(globalStr)
+	if err != nil {
+		t.Fatalf("failed to parse global yaml: %v", err)
+	}
+
+	settings := NewSettingsFromYAML("ipapi", yamlConfig, globalConfig)
+
+	if settings.name != "red" {
+		t.Errorf("expected default name color 'red', got %q", settings.name)
+	}
+	if settings.value != "white" {
+		t.Errorf("expected default value color 'white', got %q", settings.value)
+	}
+	if settings.Common == nil {
+		t.Fatal("expected Common to be set")
+	}
+	if len(settings.args) != 0 {
+		t.Errorf("expected empty args by default, got %v", settings.args)
+	}
+}
+
+func TestNewSettingsFromYAML_CustomColors(t *testing.T) {
+	yamlStr := `
+colors:
+  name: "blue"
+  value: "green"
+position:
+  top: 0
+  left: 0
+  height: 1
+  width: 1
+`
+	globalStr := `
+wtf:
+  colors:
+    border:
+      focusable: "darkslateblue"
+      focused: "orange"
+      normal: "gray"
+`
+	yamlConfig, _ := config.ParseYaml(yamlStr)
+	globalConfig, _ := config.ParseYaml(globalStr)
+
+	settings := NewSettingsFromYAML("ipapi", yamlConfig, globalConfig)
+
+	if settings.name != "blue" {
+		t.Errorf("expected name color 'blue', got %q", settings.name)
+	}
+	if settings.value != "green" {
+		t.Errorf("expected value color 'green', got %q", settings.value)
+	}
+}
+
+func TestNewSettingsFromYAML_WithArgs(t *testing.T) {
+	yamlStr := `
+args:
+  - ip
+  - city
+  - country
+position:
+  top: 0
+  left: 0
+  height: 1
+  width: 1
+`
+	globalStr := `
+wtf:
+  colors:
+    border:
+      focusable: "darkslateblue"
+      focused: "orange"
+      normal: "gray"
+`
+	yamlConfig, _ := config.ParseYaml(yamlStr)
+	globalConfig, _ := config.ParseYaml(globalStr)
+
+	settings := NewSettingsFromYAML("ipapi", yamlConfig, globalConfig)
+
+	if len(settings.args) != 3 {
+		t.Fatalf("expected 3 args, got %d", len(settings.args))
+	}
+}
+
+func TestNewSettingsFromYAML_Constants(t *testing.T) {
+	if defaultFocusable != false {
+		t.Error("expected defaultFocusable to be false")
+	}
+	if defaultTitle != "IP API" {
+		t.Errorf("expected defaultTitle 'IP API', got %q", defaultTitle)
+	}
+}

modules/ipaddresses/ipapi/widget.go

@@ -20,6 +20,10 @@ type Widget struct {
 
 	result   string
 	settings *Settings
+
+	// apiURL is the base URL for the ip-api.com service.
+	// It defaults to the public endpoint but can be overridden for testing.
+	apiURL string
 }
 
 type ipinfo struct {
@@ -65,12 +69,15 @@ var argLookup = map[string]string{
 	"reversedns":    "Reverse DNS",
 }
 
+const defaultAPIURL = "http://ip-api.com/json?fields=66846719"
+
 // NewWidget constructor
 func NewWidget(tviewApp *tview.Application, redrawChan chan bool, settings *Settings) *Widget {
 	widget := Widget{
 		TextWidget: view.NewTextWidget(tviewApp, redrawChan, nil, settings.Common),
 
 		settings: settings,
+		apiURL:   defaultAPIURL,
 	}
 
 	widget.View.SetWrap(false)
@@ -88,7 +95,7 @@ func (widget *Widget) Refresh() {
 // this method reads the config and calls ipinfo for ip information
 func (widget *Widget) ipinfo() {
 	client := &http.Client{}
-	req, err := http.NewRequest("GET", "http://ip-api.com/json?fields=66846719", http.NoBody)
+	req, err := http.NewRequest("GET", widget.apiURL, http.NoBody)
 	if err != nil {
 		widget.result = err.Error()
 		return