Add unit tests for modules/ipaddresses/ipapi (0% → 83.7% coverage) - #2154
Open
Seanstoppable wants to merge 1 commit into
Open
Add unit tests for modules/ipaddresses/ipapi (0% → 83.7% coverage)#2154Seanstoppable wants to merge 1 commit into
Seanstoppable wants to merge 1 commit into
Conversation
- Add widget_test.go with httptest-based API mocking - Add settings_test.go for configuration parsing - Test IP data parsing, display formatting, color settings, error paths - Table-driven tests for custom args and field filtering - Make apiURL injectable on Widget for testability (no behavior change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the
modules/ipaddresses/ipapipackage, bringing test coverage from 0% to 83.7%.Changes
widget_test.go— 16 tests covering:formatableTextoutput formattingsetResultwith default/custom args, color settings, empty data, invalid argsipinfo()HTTP integration viahttptest(success, invalid JSON, connection errors, invalid URLs, empty responses, full realistic response parsing)argLookupmap completenesssettings_test.go— 4 tests covering:widget.go— Minor refactor: extractedapiURLfield withdefaultAPIURLconstant so the HTTP endpoint is injectable in tests. No behavior change in production.Testing