-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: sync override settings #14782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sync override settings #14782
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'astro': patch | ||
| --- | ||
|
|
||
| Improves syncing |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -251,7 +251,26 @@ async function syncContentCollections( | |
| ssr: { external: [] }, | ||
| logLevel: 'silent', | ||
| }, | ||
| { settings, logger, mode, command: 'build', fs, sync: true, routesList, manifest }, | ||
| { | ||
| // Prevent mutation of specific properties by vite plugins during sync | ||
| settings: { | ||
| ...settings, | ||
| // Prevent mutation by vite plugins during sync | ||
ematipico marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| buildOutput: undefined, | ||
florian-lefebvre marked this conversation as resolved.
Show resolved
Hide resolved
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think we can achieve this using TypeScript? I know it has the type
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think so in this context. Because we still need it to be reassigned at some point, so we can't just update |
||
| // Sync causes font resources and style hashes to be duplicated | ||
| injectedCsp: { | ||
florian-lefebvre marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| fontResources: new Set(), | ||
| styleHashes: [], | ||
| }, | ||
| }, | ||
| logger, | ||
| mode, | ||
| command: 'build', | ||
| fs, | ||
| sync: true, | ||
| routesList, | ||
| manifest, | ||
| }, | ||
| ), | ||
| ); | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.