-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: sync override settings #14782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sync override settings #14782
Conversation
🦋 Changeset detectedLatest commit: 1ba4867 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 Changeset Validation Results❌ Changeset validation failed Issues Found:
|
CodSpeed Performance ReportMerging #14782 will not alter performanceComparing Summary
Footnotes |
| settings: { | ||
| ...settings, | ||
| // Prevent mutation by vite plugins during sync | ||
| buildOutput: undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can achieve this using TypeScript? I know it has the type Readonly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so in this context. Because we still need it to be reassigned at some point, so we can't just update AstroSettings['buildOutput']
Changes
syncdoes not mess with themTesting
Should pass
Docs
Changeset. Technically not required but I prefer to play it safe