-
Notifications
You must be signed in to change notification settings - Fork 39
feat(new-registration): add flows anonymous usage data (WPB-17529) #4088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@@ -82,6 +90,7 @@ class CreateAccountDataDetailViewModel @Inject constructor( | |||
private fun onEmailContinue() { | |||
detailsState = detailsState.copy(loading = true, continueEnabled = false) | |||
viewModelScope.launch { | |||
delay(ANALYTICS_INIT_WARMUP_THRESHOLD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my favorite, but the Countly SDK in my tests it hardly takes a half a second to init (is not sync), so adding this as a way to wait and then proceed for the first screens tracking.
is CreateAccountUsernameScreenDestination, | ||
is CreateAccountVerificationCodeScreenDestination, | ||
is CreateAccountDataDetailScreenDestination, | ||
is CreateAccountSelectorScreenDestination, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All related to hide the sync bar on the new registrations flows, thanks @saleniuk for the hint.
...-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I don't have much to add to your amazing work 🔥 just a very small nitpick comment that I also might be wrong 😅
Apart from that, awaiting for the approvals 👌🏻
app/src/main/kotlin/com/wire/android/analytics/FinalizeRegistrationAnalyticsMetadataUseCase.kt
Show resolved
Hide resolved
|
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (71.25%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4088 +/- ##
===========================================
+ Coverage 47.75% 47.83% +0.08%
===========================================
Files 502 504 +2
Lines 17582 17649 +67
Branches 2899 2907 +8
===========================================
+ Hits 8396 8443 +47
- Misses 8306 8327 +21
+ Partials 880 879 -1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Built wire-android-staging-compat-pr-4088.apk is available for download |
Built wire-android-dev-debug-pr-4088.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
As a part of the final step for new registration flows we need to provide countly tracking in case the user allows it.
Solutions
Needs release with
Testing
Test Coverage (Optional)
How to Test
Connect to staging or prod, go to Analytics dashboard and see the events there when the consent by the user was granted.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.