Skip to content

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jun 27, 2025

StoryWPB-17529 [Android] New Registration Flows - Personal account countly tracking


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to be able to set on the registration flow an analytics ID and then persist/carry over to the user when succeeded.

Solutions

Add use case to set the track ID by reusing the current repository function. This will be called for the user from the (android) app, and add a Result for the case of anonymous analytics.

Needs release with

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jun 27, 2025

Test Results

0 tests   - 3 742   0 ✅  - 3 633   0s ⏱️ - 6m 27s
0 suites  -   639   0 💤  -   109 
0 files    -   639   0 ❌ ±    0 

Results for commit 2d8b68a. ± Comparison against base commit dcb21c6.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.35%. Comparing base (dcb21c6) to head (2d8b68a).

Files with missing lines Patch % Lines
.../logic/data/analytics/AnalyticsIdentifierResult.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3494   +/-   ##
==========================================
  Coverage      50.35%   50.35%           
  Complexity        40       40           
==========================================
  Files           1566     1567    +1     
  Lines          62043    62048    +5     
  Branches        5513     5513           
==========================================
+ Hits           31243    31247    +4     
- Misses         28659    28660    +1     
  Partials        2141     2141           
Files with missing lines Coverage Δ
...e/analytics/SetNewUserTrackingIdentifierUseCase.kt 100.00% <100.00%> (ø)
.../logic/data/analytics/AnalyticsIdentifierResult.kt 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb21c6...2d8b68a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jun 27, 2025

Datadog Report

Branch report: feat/new-regs-analytics
Commit report: 4bf9783
Test service: kalium-jvm

✅ 0 Failed, 3634 Passed, 109 Skipped, 53.33s Total Time

@yamilmedina yamilmedina changed the title feat: new registration flows use case to set analytics id from the app (WPB-17529) feat: new registration flows - add use case to set analytics ID from the app (WPB-17529) Jun 27, 2025
Copy link
Contributor

github-actions bot commented Jun 27, 2025

@yamilmedina yamilmedina changed the title feat: new registration flows - add use case to set analytics ID from the app (WPB-17529) feat(new-registration): add use case to set analytics ID from the app (WPB-17529) Jun 27, 2025
@yamilmedina
Copy link
Contributor Author

Waiting for wireapp/wire-android#4088 to merge this one.

@MohamadJaara MohamadJaara added this pull request to the merge queue Jun 30, 2025
@MohamadJaara MohamadJaara removed this pull request from the merge queue due to a manual request Jun 30, 2025
Copy link

sonarqubecloud bot commented Jul 3, 2025

@yamilmedina yamilmedina added this pull request to the merge queue Jul 3, 2025
Merged via the queue into develop with commit 89fb293 Jul 3, 2025
23 checks passed
@yamilmedina yamilmedina deleted the feat/new-regs-analytics branch July 3, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants