Skip to content

feat: use import.meta.ROLLDOWN_FILE_URL_* for assets in JS - #22888

Merged
sapphi-red merged 3 commits into
mainfrom
feat/use-rollup-file-url-for-assets-in-js
Aug 21, 2026
Merged

feat: use import.meta.ROLLDOWN_FILE_URL_* for assets in JS#22888
sapphi-red merged 3 commits into
mainfrom
feat/use-rollup-file-url-for-assets-in-js

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Jul 7, 2026

Copy link
Copy Markdown
Member

Part of the "Use of import.meta.ROLLUP_FILE_URL_referenceId" in #22709 (comment)

This change allows Rolldown plugins using import.meta.ROLLDOWN_FILE_URL_* to work well with the base option and renderBuiltUrl option. But this does not convert URL of those assets to data URL. For that #22709 (comment) is needed.
This PR migrates the asset plugin to use that approach.

@sapphi-red sapphi-red changed the title feat: use import.meta.ROLLUP_FILE_URL_* for assets in JS feat: use import.meta.ROLLDOWN_FILE_URL_* for assets in JS Jul 17, 2026
@sapphi-red
sapphi-red force-pushed the refactor/exclude-postfix-from-vite-asset branch from 8e95035 to 9e6975b Compare July 31, 2026 07:54
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-assets-in-js branch from 2f1bf1f to 0cf8fd6 Compare July 31, 2026 07:54
@sapphi-red
sapphi-red force-pushed the refactor/exclude-postfix-from-vite-asset branch from 9e6975b to 220ccd8 Compare July 31, 2026 08:43
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-assets-in-js branch from 0cf8fd6 to b0c338e Compare July 31, 2026 08:43
@sapphi-red sapphi-red added the p3-significant High priority enhancement (priority) label Jul 31, 2026
@sapphi-red sapphi-red added this to the 8.3 milestone Jul 31, 2026
@sapphi-red
sapphi-red marked this pull request as ready for review July 31, 2026 09:46
bluwy
bluwy previously approved these changes Aug 3, 2026
Base automatically changed from refactor/exclude-postfix-from-vite-asset to main August 21, 2026 10:11
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-assets-in-js branch from b0c338e to 28d9165 Compare August 21, 2026 10:11
@sapphi-red
sapphi-red merged commit 4366ac4 into main Aug 21, 2026
29 of 30 checks passed
@sapphi-red
sapphi-red deleted the feat/use-rollup-file-url-for-assets-in-js branch August 21, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-significant High priority enhancement (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants