Skip to content

feat: use import.meta.ROLLDOWN_FILE_URL_* for other plugins - #22894

Merged
sapphi-red merged 3 commits into
mainfrom
feat/use-rollup-file-url-for-other-plugins
Aug 21, 2026
Merged

feat: use import.meta.ROLLDOWN_FILE_URL_* for other plugins#22894
sapphi-red merged 3 commits into
mainfrom
feat/use-rollup-file-url-for-other-plugins

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Jul 8, 2026

Copy link
Copy Markdown
Member

Part of the "Use of import.meta.ROLLUP_FILE_URL_referenceId" in #22709 (comment)

Similar to #22888 but for the other plugins.

fixes #13996

@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-other-plugins branch 3 times, most recently from efedb8f to 306743d Compare July 17, 2026 07:15
@sapphi-red sapphi-red changed the title feat: use import.meta.ROLLUP_FILE_URL_* for other plugins feat: use import.meta.ROLLDOWN_FILE_URL_* for other plugins Jul 17, 2026
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-other-plugins branch from 306743d to 764475d Compare July 17, 2026 07:17
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-assets-in-js branch from 2f1bf1f to 0cf8fd6 Compare July 31, 2026 07:54
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-other-plugins branch from 764475d to 905722e Compare July 31, 2026 07:54
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-assets-in-js branch from 0cf8fd6 to b0c338e Compare July 31, 2026 08:43
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-other-plugins branch from 905722e to 0c59126 Compare July 31, 2026 08:43
@sapphi-red sapphi-red added this to the 8.3 milestone Jul 31, 2026
@sapphi-red sapphi-red added the p3-significant High priority enhancement (priority) label Jul 31, 2026
@sapphi-red
sapphi-red marked this pull request as ready for review July 31, 2026 09:51
bluwy
bluwy previously approved these changes Aug 3, 2026

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see we can defer a lot of the worker reference handling to rolldown

@sapphi-red
sapphi-red dismissed bluwy’s stale review August 21, 2026 10:11

The merge-base changed after approval.

@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-assets-in-js branch from b0c338e to 28d9165 Compare August 21, 2026 10:11
Base automatically changed from feat/use-rollup-file-url-for-assets-in-js to main August 21, 2026 10:18
@sapphi-red
sapphi-red force-pushed the feat/use-rollup-file-url-for-other-plugins branch from 0c59126 to 30c52ba Compare August 21, 2026 10:27
@sapphi-red
sapphi-red merged commit e38f29e into main Aug 21, 2026
27 of 29 checks passed
@sapphi-red
sapphi-red deleted the feat/use-rollup-file-url-for-other-plugins branch August 21, 2026 11:14
This was referenced Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-significant High priority enhancement (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chunk hash did not change when I only update experimental.renderBuiltUrl function.

2 participants