Skip to content

chore(core): improve dock button a11y #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Jul 28, 2026
Merged

chore(core): improve dock button a11y #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/client/webcomponents/components/dock/DockEdge.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ const contentClass = computed(() => {
>
<button
ref="positionButton"
aria-label="Edge position"
class="p1.5 rounded hover:bg-active transition op75 hover:op100"
@pointerenter="showTooltip(positionButton, 'Edge position')"
@pointerleave="hideTooltip"
Expand All @@ -250,6 +251,7 @@ const contentClass = computed(() => {
</button>
<button
ref="floatButton"
aria-label="Float mode"
class="p1.5 rounded hover:bg-active transition op50 hover:op100"
@pointerenter="showTooltip(floatButton, 'Float mode')"
@pointerleave="hideTooltip"
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/client/webcomponents/components/dock/DockEntry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ useEventListener('pointerdown', () => {
>
<button
ref="button"
:aria-label="dock.title"
Comment thread
webfansplz marked this conversation as resolved.
:class="[
isVertical ? 'rotate-270' : '',
isDimmed ? 'op50 saturate-0' : '',
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/client/webcomponents/components/dock/DockGroupSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ const moreButtonActive = computed(() => selectedInOverflow.value || isOverflowPa
<button
v-for="member of members"
:key="member.id"
:aria-label="member.title"
Comment thread
webfansplz marked this conversation as resolved.
class="relative flex items-center justify-center w-8 h-8 rounded-lg transition"
:class="selectedId === member.id ? 'text-primary bg-active' : 'op60 hover:op100 hover:bg-active'"
@pointerenter="showTooltip($event, member.title)"
Expand All @@ -167,6 +168,7 @@ const moreButtonActive = computed(() => selectedInOverflow.value || isOverflowPa
<button
v-if="hasOverflow"
ref="moreButton"
aria-label="Show more"
class="relative flex items-center justify-center w-8 h-8 rounded-lg transition mt-auto flex-none"
:class="moreButtonActive ? 'text-primary bg-active' : 'op60 hover:op100 hover:bg-active'"
@pointerenter="showTooltip($event, 'Show more')"
Expand Down
Loading