chore(core): improve dock button a11y - #484
Merged
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves accessibility of icon-only dock buttons in the DevTools webcomponents client by adding accessible names (aria-label) so screen readers can announce what each dock control does.
Changes:
- Add
aria-labelto dock member buttons in the group sidebar. - Add
aria-labelto the overflow (“Show more”) button in the group sidebar. - Add
aria-labelto individual dock entry buttons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/client/webcomponents/components/dock/DockGroupSidebar.vue | Adds aria-labels for member buttons and the overflow button to improve screen reader labeling. |
| packages/core/src/client/webcomponents/components/dock/DockEntry.vue | Adds aria-label to the dock entry button for icon-only accessibility. |
Comments suppressed due to low confidence (1)
packages/core/src/client/webcomponents/components/dock/DockGroupSidebar.vue:171
- With a fixed
aria-labelon the overflow button, the visible overflow badge/count inside the button won’t be announced by screen readers. Consider including the current overflow count in the label so the same information is available non-visually.
aria-label="Show more"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.