Skip to content

chore(core): improve dock button a11y - #484

Merged
antfu merged 1 commit into
mainfrom
fix/btn-a11y
Jul 28, 2026
Merged

chore(core): improve dock button a11y#484
antfu merged 1 commit into
mainfrom
fix/btn-a11y

Conversation

@webfansplz

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 27, 2026 13:43
@pkg-pr-new

pkg-pr-new Bot commented Jul 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@484

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@484

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@484

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@484

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@484

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@484

commit: cbcc555

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves accessibility of icon-only dock buttons in the DevTools webcomponents client by adding accessible names (aria-label) so screen readers can announce what each dock control does.

Changes:

  • Add aria-label to dock member buttons in the group sidebar.
  • Add aria-label to the overflow (“Show more”) button in the group sidebar.
  • Add aria-label to individual dock entry buttons.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/core/src/client/webcomponents/components/dock/DockGroupSidebar.vue Adds aria-labels for member buttons and the overflow button to improve screen reader labeling.
packages/core/src/client/webcomponents/components/dock/DockEntry.vue Adds aria-label to the dock entry button for icon-only accessibility.
Comments suppressed due to low confidence (1)

packages/core/src/client/webcomponents/components/dock/DockGroupSidebar.vue:171

  • With a fixed aria-label on the overflow button, the visible overflow badge/count inside the button won’t be announced by screen readers. Consider including the current overflow count in the label so the same information is available non-visually.
      aria-label="Show more"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@antfu
antfu merged commit ad040d2 into main Jul 28, 2026
10 checks passed
@antfu
antfu deleted the fix/btn-a11y branch July 28, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants