Skip to content

fix(core): align grouped iframe address bar with sidebar #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Jul 27, 2026
Merged

fix(core): align grouped iframe address bar with sidebar #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/core/src/client/webcomponents/components/views/ViewIframe.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { IframePanes } from 'iframe-pane'
import type { CSSProperties } from 'vue'
import { REMOTE_CONNECTION_KEY } from '@vitejs/devtools-kit/constants'
import { computed, nextTick, onMounted, onUnmounted, ref, useTemplateRef, watchEffect } from 'vue'
import { getEntryGroup } from '../../state/dock-settings'
import { sharedStateToRef } from '../../state/docks'

const props = defineProps<{
Expand Down Expand Up @@ -45,6 +46,13 @@ function stripRemoteConnectionParam(url: string): string {
const settings = sharedStateToRef(props.context.docks.settings)
const showAddressBar = computed(() => settings.value.showIframeAddressBar ?? true)
const isEdgeMode = computed(() => props.context.panel.store.mode === 'edge')
const addressBarBorderClass = computed(() => {
if (isEdgeMode.value)
return 'border-b'
if (getEntryGroup(props.context.docks.entries, props.entry))
return 'border-t border-r rounded-tr-md'
return 'border rounded-t-md border-b-0'
})
const ADDRESS_BAR_HEIGHT = 40

const isLoading = ref(true)
Expand Down Expand Up @@ -263,8 +271,8 @@ onUnmounted(() => {
<div class="w-full h-full flex flex-col">
<div
v-if="showAddressBar"
class="flex-none px-2 w-full flex items-center gap-1"
:class="isEdgeMode ? 'border-b border-base' : 'border rounded-t-md border-base border-b-0'"
class="flex-none px-2 w-full flex items-center gap-1 border-base"
:class="addressBarBorderClass"
:style="{ height: `${ADDRESS_BAR_HEIGHT}px` }"
>
<!-- Navigation buttons (hidden for cross-origin) -->
Expand Down
Loading