fix(core): align grouped iframe address bar with sidebar - #482
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a visual artifact in the core webcomponents client: when an iframe view is shown alongside a dock group sidebar, the iframe address bar now uses a different border/radius shape to avoid a duplicated inner border and an incorrect top-left corner radius, while preserving the existing look for ungrouped iframes and for edge mode.
Changes:
- Add group-awareness to the iframe address bar styling by detecting whether the current iframe entry belongs to a registered dock group.
- Adjust the address bar’s border/radius classes for grouped vs ungrouped iframe views, keeping edge mode behavior unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the duplicated inner border and top-left radius shown between a group sidebar and a floating iframe address bar. See:
The address bar now adjusts its border shape when the iframe belongs to a dock group, while preserving the existing appearance for ungrouped iframe views and edge mode.