Skip to content

fix(core): align grouped iframe address bar with sidebar - #482

Merged
antfu merged 1 commit into
mainfrom
fix/grouped-iframe-address-bar
Jul 27, 2026
Merged

fix(core): align grouped iframe address bar with sidebar#482
antfu merged 1 commit into
mainfrom
fix/grouped-iframe-address-bar

Conversation

@webfansplz

Copy link
Copy Markdown
Member

Fix the duplicated inner border and top-left radius shown between a group sidebar and a floating iframe address bar. See:

image

The address bar now adjusts its border shape when the iframe belongs to a dock group, while preserving the existing appearance for ungrouped iframe views and edge mode.

Copilot AI review requested due to automatic review settings July 26, 2026 14:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a visual artifact in the core webcomponents client: when an iframe view is shown alongside a dock group sidebar, the iframe address bar now uses a different border/radius shape to avoid a duplicated inner border and an incorrect top-left corner radius, while preserving the existing look for ungrouped iframes and for edge mode.

Changes:

  • Add group-awareness to the iframe address bar styling by detecting whether the current iframe entry belongs to a registered dock group.
  • Adjust the address bar’s border/radius classes for grouped vs ungrouped iframe views, keeping edge mode behavior unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pkg-pr-new

pkg-pr-new Bot commented Jul 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@482

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@482

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@482

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@482

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@482

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@482

commit: a0c4f38

@antfu
antfu merged commit 95c9f2d into main Jul 27, 2026
11 checks passed
@antfu
antfu deleted the fix/grouped-iframe-address-bar branch July 27, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants