[viostor] Introduce Registry read capability #1297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benyamin-codez
requested review from
YanVugenfirer and
vrozenfe
as code owners
This was referenced Feb 17, 2025
MartinDrab
reviewed
Feb 17, 2025
Introduces a Registry read capability: 1. Implemented in VioStorReadRegistryParameter() 2. Requires neo helper CopyBufferToAnsiString() 3. Adds capacity to both detect and read DWORD values in: (a) HKLM\SYSTEM\CurrentControlSet\Services\viostor\Paramaters\Device (b) HKLM\SYSTEM\CurrentControlSet\Services\viostor\Paramaters\Device(d) NOT WORKING 4. Also supports per-HBA values for \Parameters\Device\Valuename_123 when the \Parameters\Device(d) key is unavailable (presently broken) 5. Adds TRACE_REGISTRY WPP tracing flag Signed-off-by: benyamin-codez <[email protected]>
benyamin-codez
force-pushed
the
viostor-read-reg-per-hba
branch
from
2cd9088 to
eb2017b
Compare
Contributor
Author
|
Everyone pleased enough with this one? Not having a solution for the issue with the built-in Did anyone have any comments about the in-line |
Collaborator
|
Let's wait for @vrozenfe review |
This was referenced Feb 26, 2025
Collaborator
|
[Jenkins CI]: Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a Registry read capability:
VioStorReadRegistryParameter()CopyBufferToAnsiString()DWORDvalues in:(a)
HKLM\SYSTEM\CurrentControlSet\Services\viostor\Paramaters\Device(b)
HKLM\SYSTEM\CurrentControlSet\Services\viostor\Paramaters\Device(d)(NOT WORKING)\Parameters\Device\Valuename_123when the\Parameters\Device(d)key is unavailable (presently broken)TRACE_REGISTRYWPP tracing flag