Skip to content

Conversation

@benyamin-codez
Copy link
Contributor

Changes the MAX_PHYS_SEGMENTS limit to 1,024 equal to QEMU's VIRTQUEUE_MAX_SIZE.

This results in:

  1. adaptExt->max_segments = 1024
  2. ConfigInfo->NumberOfPhysicalBreaks = 1025
  3. ConfigInfo->MaximumTransferLength = 4MiB (1,024 * PAGE_SIZE = 4,096KiB)

Changes the MAX_PHYS_SEGMENTS limit to 1,024 equal to QEMU's VIRTQUEUE_MAX_SIZE.

This results in:
1. adaptExt->max_segments = 1024
2. ConfigInfo->NumberOfPhysicalBreaks = 1025
3. ConfigInfo->MaximumTransferLength = 4MiB (1,024 * PAGE_SIZE = 4,096KiB)

Signed-off-by: benyamin-codez <[email protected]>
@benyamin-codez
Copy link
Contributor Author

I wouldn't much care to attempt merging this until after the following PRs merge:

#1289
#1295
#1297
#1298
#1299
#1304

Here is a pic showing the VQ Buffer Length and SRB DataTransferLength at the tail end of a 4MiB sequential read:

viostor_4M_MaxXferLen_tailend

@YanVugenfirer
Copy link
Collaborator

[Jenkins CI]: Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants