Migrate SDK to connect-es #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
commented
Sep 30, 2024
| :license_links: https://www.npmjs.com/package/@improbable-eng/grpc-web-fake-transport | ||
| :versions: [] | ||
| :when: 2023-05-01 18:11:37.804857463 Z | ||
| - - :approve |
There was a problem hiding this comment.
Need approval for this addition. It is apache 2 and bsd-3
edaniels
commented
Sep 30, 2024
| @@ -31,7 +31,7 @@ test-watch: $(node_modules) build-buf | |||
| lint: $(node_modules) build-buf | |||
| npm run lint | |||
| npm run typecheck | |||
| npm run check | |||
| npm run check -- --ignore=@bufbuild/protobuf | |||
There was a problem hiding this comment.
the new major version (2) is incompatible with other packages used by connect-es
njooma
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to check some integrations with app but this ready to review.
Major Changes
Minor Fixes
This PR is unfortunately huge but everything works and is tested across every example. Happy to go over anything in person though or if there's a better way to split it up, just holler. But... it's more deletions than additions and everything should be easier to read.