Migrate to connect-es #4417
Migrate to connect-es #4417
Conversation
edaniels
requested review from
ethanlookpotts,
micheal-parks,
DTCurrie and
zaporter-work
as code owners
viambot
added
the
safe to test
| const client = new MovementSensorClient(robotClient, name, { | ||
| requestLogger: rcLogConditionally, |
There was a problem hiding this comment.
[aside] Do you know if these clients expensive to construct? I traced the trail down through connect-es PromiseClient but didn't go much further.
There was a problem hiding this comment.
they are O(n) calls where n is the number of proto methods. If I were rewriting how this would work now, I wouldn't keep creating clients but just have each component have a cached client or robot client.
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
| movement_sensor: 'movementSensorService', | ||
| navigation: 'navigationService', | ||
| power_sensor: 'powerSensorService', | ||
| sensors: 'sensorsService', |
There was a problem hiding this comment.
Does the sensors service no longer exist? I was under the impression it still existed.
There was a problem hiding this comment.
there's no reified client for it other than the promise client. is anyone running a do command against a sensors service though?
There was a problem hiding this comment.
They shouldn't be - we have every intention to get rid of it - but if it exists, I'm sure someone is using it. We can skip it, was just curious.
There was a problem hiding this comment.
if a problem comes up with it, it wont be hard to get it working again!
|
|
||
| return response?.toObject().sensorNamesList ?? []; | ||
| const request = new sensorsApi.GetSensorsRequest({ name }); | ||
| const resp = await robotClient.sensorsService.getSensors(request); |
There was a problem hiding this comment.
Why not create SensorsClient like the other wrappers?
There was a problem hiding this comment.
because the TS SDK never had one
There was a problem hiding this comment.
note there's a SensorClient but not a SensorsClient
web/frontend/src/api/power-sensor.ts
Outdated
There was a problem hiding this comment.
Why are the responses for getVoltage, getCurrent, and getPower arrays now?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah interesting, what is the bool that is the second entry? Could we use array destructuring?
There was a problem hiding this comment.
I think it's something about it being AC or not
| console.error('done streaming robot status'); | ||
| $statusStream = null; | ||
| }); | ||
| })().catch(console.error); |
There was a problem hiding this comment.
Will this catch actually catch anything since the whole thing is wrapped in a try/catch?
viambot
added
safe to test
|
Manual testing LGTM - I wasn't seeing any operations but not sure that I would with the fakes. There are hopefully very few users on this so I think we're safe and can fix forward if anything comes up. |
Ah yeah I managed to get one using a motor gofor, many of them are too instantaneous though |
edaniels
force-pushed
the
ts-sdk-connect-es
branch
from
92c8f27 to
37794d5
Compare
viambot
added
safe to test
Depends on viamrobotics/viam-typescript-sdk#368
There's nothing very interesting here and testing so far seems to have this work.