RSDK-11641 — Make GetImages feature flag for RDK stream server #5258
+872
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
hexbabe
commented
Sep 5, 2025
Comment on lines
+19
to
+25
| var streamableImageMIMETypes = map[string]interface{}{ | ||
| rutils.MimeTypeRawRGBA: nil, | ||
| rutils.MimeTypeRawDepth: nil, | ||
| rutils.MimeTypeJPEG: nil, | ||
| rutils.MimeTypePNG: nil, | ||
| rutils.MimeTypeQOI: nil, | ||
| } |
There was a problem hiding this comment.
I added an f.name print in sniff
f.name ppm
f.name qoi
f.name bmp
f.name tiff
f.name tiff
f.name gif
f.name jpeg
In addition to the first four supported formats, we also support QOI.
…n when filter; Add test that checks that; Add test that checks lazy decode config error
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the test notes I took that guided the unit tests written for this new logic here: RSDK-11641
TODO: