Upload image to dataset poc #5089
Conversation
viambot
added
the
safe to test
| @@ -50,6 +50,8 @@ type Service interface { | |||
| resource.Resource | |||
| // Sync will sync data stored on the machine to the cloud. | |||
| Sync(ctx context.Context, extra map[string]interface{}) error | |||
| UploadImageToDataset(ctx context.Context, image []byte, datasetIDs, tags []string, | |||
There was a problem hiding this comment.
don't we need the mime type?
can we also have an image.Image version even if just for the go sdk?
There was a problem hiding this comment.
yes! we definitely should have the MIME type. Lemme add that.
Do you want the image.Image version instead or in addition? If we pass in MIME type then it’s not an issue.
| s.logger.Errorw("error reading file", "err", err) | ||
| return err | ||
| } | ||
| s.syncArbitraryFile(f, tags, datasetIDs, 0, s.logger) |
There was a problem hiding this comment.
is this sync or async?
if we're writing to disk anyway, we can make async.
otherwise, let's not write to disk
There was a problem hiding this comment.
It should be async. The reason to write to disk is because all of our functionality is written to take in a os.File and in the name of not rewriting everything just to account for this, thought it would be easier just to write to disk and delete it afterwards.
No description provided.