DATA-4220: Update Go SDK + CLI to have enable backfill argument for CreateDataPipeline #5084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
| @@ -1349,7 +1349,8 @@ func (d *DataClient) GetDataPipeline(ctx context.Context, id string) (*DataPipel | |||
|
|
|||
| // CreateDataPipeline creates a new data pipeline using the given query and schedule. | |||
| func (d *DataClient) CreateDataPipeline( | |||
| ctx context.Context, organizationID, name string, query []map[string]interface{}, schedule string, opts *CreateDataPipelineOptions, | |||
| ctx context.Context, organizationID, name string, query []map[string]interface{}, schedule string, | |||
| enableBackfill bool, opts *CreateDataPipelineOptions, | |||
There was a problem hiding this comment.
Should we move this to the create pipeline options? To avoid this being a breaking change or do we want to for users to set it?
There was a problem hiding this comment.
enablebackfill is required, so i feel like it would be misleading to put it under options
vijayvuyyuru
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the enable backfill argument for CreateDataPipeline to both the Go SDK and the CLI