-
Notifications
You must be signed in to change notification settings - Fork 0
CI for Node #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghost
wants to merge
5
commits into
master
Choose a base branch
from
varun7447-patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CI for Node #2
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Node CI | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
This conversation was marked as resolved.
|
||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [8.x, 10.x, 12.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
|
This conversation was marked as resolved.
|
||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - name: npm install, build, and test | ||
| run: | | ||
| npm ci | ||
| npm run build --if-present | ||
| npm test | ||
|
This conversation was marked as resolved.
|
||
| env: | ||
| CI: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`App Contains the compiled JavaScript 1`] = `"!function(t){var e={};function n(r){if(e[r])return e[r].exports;var l=e[r]={i:r,l:!1,exports:{}};return t[r].call(l.exports,l,l.exports,n),l.l=!0,l.exports}n.m=t,n.c=e,n.d=function(t,e,r){n.o(t,e)||Object.defineProperty(t,e,{enumerable:!0,get:r})},n.r=function(t){\\"undefined\\"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(t,Symbol.toStringTag,{value:\\"Module\\"}),Object.defineProperty(t,\\"__esModule\\",{value:!0})},n.t=function(t,e){if(1&e&&(t=n(t)),8&e)return t;if(4&e&&\\"object\\"==typeof t&&t&&t.__esModule)return t;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,\\"default\\",{enumerable:!0,value:t}),2&e&&\\"string\\"!=typeof t)for(var l in t)n.d(r,l,function(e){return t[e]}.bind(null,l));return r},n.n=function(t){var e=t&&t.__esModule?function(){return t.default}:function(){return t};return n.d(e,\\"a\\",e),e},n.o=function(t,e){return Object.prototype.hasOwnProperty.call(t,e)},n.p=\\"\\",n(n.s=1)}([function(t,e,n){\\"use strict\\";n.r(e),n.d(e,\\"default\\",(function(){return r}));class r{constructor(t,e){this.p1=t,this.p2=e,this.board=[[null,null,null],[null,null,null],[null,null,null]],this.player=Math.random()<.5?this.p1:this.p2,this.sym=\\"X\\"}turn(t,e){e=e||t,this.board[t][e]=this.sym}nextPlayer(){this.player=this.player===this.p1?this.p2:this.p1,this.sym=\\"X\\"===this.sym?\\"O\\":\\"X\\"}hasWinner(){return this.rowWin()||this.colWin()||this.diagWin()}rowWin(){let t=!1;for(let e=0;e<3;e++){const n=this.board[e];null!==n[0]&&(t=t||n[0]===n[1]&&n[0]===n[2])}return t}colWin(){let t=!1;for(let e=0;e<3;e++){const n=this.board;null!==n[0][e]&&(t=t||n[0][e]===n[1][e]&&n[0][e]===n[2][e])}return t}diagWin(){const t=this.board;return null!==t[0][0]&&t[0][0]===t[1][1]&&t[0][0]===t[2][2]||null!==t[0][2]&&t[0][2]===t[1][1]&&t[0][2]===t[2][0]}}},function(t,e,n){n(2),t.exports=n(0)},function(t,e,n){\\"use strict\\";n.r(e);var r=n(0);let l,o;for(;!l;)l=window.prompt(\\"Enter player 1 name:\\");for(;!o&&l!==o;)o=window.prompt(l===o?\`Please enter a different name than \${l}.\`:\\"Enter player 2 name:\\");window.onload=()=>{const t=new r.default(l,o),e=document.getElementById(\\"turn\\"),n=document.getElementById(\\"player\\");n.innerText=t.player,document.querySelectorAll(\\"td\\").forEach(r=>{r.onclick=l=>{r.onclick=void 0,l.target.innerText=t.sym,l.target.onclick=void 0;const[o,i]=l.target.classList;t.turn(o,i),t.hasWinner()?(e.innerText=\`\${t.player} wins!\`,document.querySelectorAll(\\"td\\").forEach(t=>{t.onclick=void 0})):(t.nextPlayer(),n.innerText=t.player)}})}}]);"`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| const Game = require('../src/game').default | ||
| const fs = require('fs') | ||
|
|
||
| describe('App', () => { | ||
| it('Contains the compiled JavaScript', async (done) => { | ||
| fs.readFile('./public/main.js', 'utf8', (err, data) => { | ||
| expect(err).toBe(null) | ||
| expect(data).toMatchSnapshot() | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('Game', () => { | ||
| let game, p1, p2 | ||
| beforeEach(() => { | ||
| p1 = 'Salem' | ||
| p2 = 'Nate' | ||
| game = new Game(p1, p2) | ||
| }) | ||
|
|
||
| describe('Game', () => { | ||
| it('Initializes with two players', async () => { | ||
| expect(game.p1).toBe('Salem') | ||
| expect(game.p2).toBe('Nate') | ||
| }) | ||
|
|
||
| it('Initializes with an empty board', async () => { | ||
| for (let r = 0; r < game.board.length; r++) { | ||
| for (let c = 0; c < game.board[r].lenght; c++) { | ||
| expect(game.board[r][c]).toBeUndefined() | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| it('Starts the game with a random player', async () => { | ||
| Math.random = () => 0.4 | ||
| expect(new Game(p1, p2).player).toBe('Salem') | ||
|
|
||
| Math.random = () => 0.6 | ||
| expect(new Game(p1, p2).player).toBe('Nate') | ||
| }) | ||
| }) | ||
|
|
||
| describe('turn', () => { | ||
| it("Inserts an 'X' into the top center", async () => { | ||
| game.turn(0, 1) | ||
| expect(game.board[0][1]).toBe('X') | ||
| }) | ||
|
|
||
| it("Inserts an 'X' into the top left", async () => { | ||
| game.turn(0) | ||
| expect(game.board[0][0]).toBe('X') | ||
| }) | ||
| }) | ||
|
|
||
| describe('nextPlayer', () => { | ||
| it('Sets the current player to be whoever it is not', async () => { | ||
| Math.random = () => 0.4 | ||
| const game = new Game(p1, p2) | ||
| expect(game.player).toBe('Salem') | ||
| game.nextPlayer() | ||
| expect(game.player).toBe('Nate') | ||
| }) | ||
| }) | ||
|
|
||
| describe('hasWinner', () => { | ||
| it('Wins if any row is filled', async () => { | ||
| for (let r = 0; r < game.board.length; r++) { | ||
| for (let c = 0; c < game.board[r].length; c++) { | ||
| game.board[r][c] = 'X' | ||
| } | ||
| expect(game.hasWinner()).toBe(true) | ||
|
|
||
| for (let c = 0; c < game.board[r].length; c++) { | ||
| game.board[r][c] = null | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| it('Wins if any column is filled', async () => { | ||
| for (let r = 0; r < game.board.length; r++) { | ||
| for (let c = 0; c < game.board[r].length; c++) { | ||
| game.board[c][r] = 'X' | ||
| } | ||
| expect(game.hasWinner()).toBe(true) | ||
|
|
||
| for (let c = 0; c < game.board[r].length; c++) { | ||
| game.board[c][r] = null | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| it('Wins if down-left diagonal is filled', async () => { | ||
| for (let r = 0; r < game.board.length; r++) { | ||
| game.board[r][r] = 'X' | ||
| } | ||
| expect(game.hasWinner()).toBe(true) | ||
| }) | ||
|
|
||
| it('Wins if up-right diagonal is filled', async () => { | ||
| for (let r = 0; r < game.board.length; r++) { | ||
| game.board[2 - r][r] = 'X' | ||
| } | ||
| expect(game.hasWinner()).toBe(true) | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.